linux-kernel - Re: [PATCH] software node: Constify node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aKXe0VnhLlhllHba@smile.fi.intel.com>
Date: Wed, 20 Aug 2025 17:42:25 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Daniel Scally <djrscally@...il.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Danilo Krummrich <dakr@...nel.org>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] software node: Constify node_group in registration
 functions

On Wed, Aug 13, 2025 at 11:03:52PM -0700, Dmitry Torokhov wrote:
> The software_node_register_node_group() and
> software_node_unregister_node_group() functions take in essence an
> array of pointers to software_node structs. Since the functions do not
> modify the array declare the argument as constant, so that static
> arrays can be declared as const and annotated as __initconst.

If it compiles and works, no objection from me from code perspective:
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

-- 
With Best Regards,
Andy Shevchenko