linux-kernel - Re: [PATCH 1/6] iio: health: afe4403: Do not store dev pointer in device struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aKXfeOi2y55L1c7A@smile.fi.intel.com>
Date: Wed, 20 Aug 2025 17:45:12 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Andrew Davis <afd@...com>
Cc: Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] iio: health: afe4403: Do not store dev pointer in
 device struct

On Wed, Aug 13, 2025 at 05:58:35PM -0500, Andrew Davis wrote:
> The device *dev is only used in probe(), so no need to store it
> in the device local data struct. In all the places in probe()
> we did use that, just use a new local variable for the same.

...

> -		afe->trig = devm_iio_trigger_alloc(afe->dev,
> +		afe->trig = devm_iio_trigger_alloc(dev,
>  						   "%s-dev%d",

It can be made one line less, but it's already applied...

>  						   indio_dev->name,
>  						   iio_device_id(indio_dev));
>  		if (!afe->trig) {
> -			dev_err(afe->dev, "Unable to allocate IIO trigger\n");
> +			dev_err(dev, "Unable to allocate IIO trigger\n");
>  			return -ENOMEM;
>  		}

-- 
With Best Regards,
Andy Shevchenko