linux-kernel - Re: [PATCH v4 3/3] iio: pressure: bmp280: Use gpiod_set_value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aKXg6h0nW-GMcy1m@smile.fi.intel.com>
Date: Wed, 20 Aug 2025 17:51:22 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Salah Triki <salah.triki@...il.com>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
	jic23@...nel.org, dlechner@...libre.com, nuno.sa@...log.com,
	andy@...nel.org, Markus.Elfring@....de
Subject: Re: [PATCH v4 3/3] iio: pressure: bmp280: Use
 gpiod_set_value_cansleep()

On Mon, Aug 18, 2025 at 10:27:32AM +0100, Salah Triki wrote:
> Switch to `gpiod_set_value_cansleep()`, which is safe to use in
> sleepable contexts like the driver probe function.

The commit message is unclear on why? aspect. You need to elaborate that some
GPIO chips may be located behind slow (and hence sleepable) busses, such as
I²C).

Code wise I agree with the change.
With amended commit message
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

-- 
With Best Regards,
Andy Shevchenko