linux-kernel - Re: [PATCH v4 1/3] iio: pressure: bmp280: Use IS_ERR() in bmp280_common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250825092231.1e02590a@jic23-huawei>
Date: Mon, 25 Aug 2025 09:22:31 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Salah Triki <salah.triki@...il.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, dlechner@...libre.com, nuno.sa@...log.com,
 andy@...nel.org, Markus.Elfring@....de
Subject: Re: [PATCH v4 1/3] iio: pressure: bmp280: Use IS_ERR() in
 bmp280_common_probe()

On Wed, 20 Aug 2025 17:48:56 +0300
Andy Shevchenko <andriy.shevchenko@...el.com> wrote:

> On Mon, Aug 18, 2025 at 10:27:30AM +0100, Salah Triki wrote:
> > `devm_gpiod_get_optional()` may return non-NULL error pointer on failure.
> > Check its return value using `IS_ERR()` and propagate the error if
> > necessary.  
> 
> > Fixes: df6e71256c84 ("iio: pressure: bmp280: Explicitly mark GPIO optional")  
> 
> > Cc: David Lechner <dlechner@...libre.com>
> > Cc: Jonathan Cameron <jic23@...nel.org>
> > Cc: Andy Shevchenko <andy@...nel.org>
> > Cc: Nuno Sá <nuno.sa@...log.com>
> > Cc: Markus Elfring <Markus.Elfring@....de>  
> 
> Please, next time move the Cc:s to be the after '---' line...
> 
> > Signed-off-by: Salah Triki <salah.triki@...il.com>
> > Reviewed-by: David Lechner <dlechner@...libre.com>
> > ---  
> 
> ...somewhere here.
> 
> It will reduce a lot the noise in the commit message. The all people will be
> Cc'ed anyway (assuming you use `git send-email`).
> 
> >  drivers/iio/pressure/bmp280-core.c | 9 +++++----
> >  1 file changed, 5 insertions(+), 4 deletions(-)  
> 
> Jonathan, would it be possible to drop them from the commit you pushed?
> 

I did so, just didn't mention it.

J