linux-kernel - Re: [PATCH v2 3/3] arm64: dts: rockchip: update pinctrl names for Radxa E52C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1D03D9D55EB70125+5dd53657-8d25-44b8-9098-d50ed83422b2@radxa.com>
Date: Wed, 20 Aug 2025 11:16:50 +0900
From: FUKAUMI Naoki <naoki@...xa.com>
To: Chukun Pan <amadeus@....edu.cn>
Cc: conor+dt@...nel.org, devicetree@...r.kernel.org, heiko@...ech.de,
 krzk+dt@...nel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v2 3/3] arm64: dts: rockchip: update pinctrl names for
 Radxa E52C

Hi Chukun,

On 8/20/25 00:00, Chukun Pan wrote:
> Hi,
> 
>> "The name of a node should be somewhat generic".
>>
>>    https://github.com/devicetree-org/devicetree-specification/blob/v0.4/source/chapter2-devicetree-basics.rst?plain=1#L193
> 
> Usually we use the name on the schematic. For example, the patch for e24c:

I don't mind using names that match the schematic, as long as the device 
tree maintainer doesn't object.

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

> https://lore.kernel.org/lkml/20250727144409.327740-4-jonas@kwiboo.se/
> 
> ```
> +	gpio-keys {
> +		compatible = "gpio-keys";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&gpio0_a0_user>;
> ```
> 
> If this is incorrect, I will abandon the pinctrl changes for
> the user key and power LED.
> 
>>> -		vcc_5v0_pwren_h: regulator-5v0-1 {
>>> -		usb_otg_pwren_h: regulator-5v0-0 {
> 
> But I don't think the above is correct.
> 
>>    https://lore.kernel.org/all/20241216113052.15696-1-naoki@radxa.com/T/#u
>>
>> (I don't understand why this only applies to me...)
> 
> I don't know this. I thought the nodenames of pinctrl and regulator
> were a bit weird, so I changed the pinctrl's.
> 
> Thanks,
> Chukun
> 
> --
> 2.25.1
> 
> 
>