[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <7988840.GXAFRqVoOG@phil>
Date: Sun, 24 Aug 2025 08:41:28 +0200
From: Heiko Stuebner <heiko@...ech.de>
To: Chukun Pan <amadeus@....edu.cn>, FUKAUMI Naoki <naoki@...xa.com>
Cc: conor+dt@...nel.org, devicetree@...r.kernel.org, krzk+dt@...nel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-rockchip@...ts.infradead.org
Subject:
Re: [PATCH v2 2/3] arm64: dts: rockchip: remove vcc_3v3_pmu regulator for
Radxa E52C
Am Mittwoch, 20. August 2025, 04:10:24 Mitteleuropäische Sommerzeit schrieb FUKAUMI Naoki:
> Hi Chukun,
>
> On 8/19/25 22:40, Chukun Pan wrote:
> > Hi,
> >
> >> How about the following instead?
> >>
> >> @@ -538,7 +538,7 @@ regulator-state-mem {
> >> };
> >> };
> >>
> >> - vcc_3v3_s3: dcdc-reg8 {
> >> + vcc_3v3_pmu: vcc_3v3_s3: dcdc-reg8 {
> >> regulator-name = "vcc_3v3_s3";
> >> regulator-always-on;
> >> regulator-boot-on;
> >
> > On rk356x, the Flash chip is usually powered by VCCIO_FLASH, which
> > is also connected through a 0 ohm resistor, so I didn't write like
> > this. e.g. https://github.com/torvalds/linux/commit/a706a593cb19
>
> I think it should match the schematic, i.e. it should be "vcc-supply =
> <&vccio_flash>;".
I very much agree :-) .
Having at least the phandle match the schematics nameing is very helpful
when someone tries to look something up between those two.
Heiko
Powered by blists - more mailing lists