linux-kernel - Re: [PATCH] scsi: aic94xx: remove self-assigned redundant code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0a345fc9-e780-486c-8724-2c313343cc51@oracle.com>
Date: Wed, 20 Aug 2025 10:24:10 +0100
From: John Garry <john.g.garry@...cle.com>
To: "Martin K. Petersen" <martin.petersen@...cle.com>, liuqiangneo@....com
Cc: James.Bottomley@...senPartnership.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, Qiang Liu <liuqiang@...inos.cn>
Subject: Re: [PATCH] scsi: aic94xx: remove self-assigned redundant code

On 20/08/2025 04:08, Martin K. Petersen wrote:
> 
>> Assigning ssp_task.retry_count to itself has no effect
> 
>>   	scb->ssp_task.data_dir = data_dir_flags[task->data_dir];
>> -	scb->ssp_task.retry_count = scb->ssp_task.retry_count;
> 
> This begs the question of what the original author intended to write.
> 

If you check commit 86344494e364, I got rid off sas_task.retry_count as 
it was never used. This means that we explicitly set 
scb->ata_task.retry_count to zero now.

I guess that they wanted to something like that for scb->ssp_task, but 
there was no sas_task member to copy from.

The value in scb->ssp_task.retry_count would be zero from 
asd_ascb_alloc() -> asd_init_ascb(). So dropping this self-assigned code 
should be ok. However, it would be nice to have consistent code for all 
protocol frame types, so we could get rid of setting 
scb->ata_task.retry_count = 0 also.