linux-kernel - Re: [PATCH] scsi: aic94xx: remove self-assigned redundant code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1tt1vqtol.fsf@ca-mkp.ca.oracle.com>
Date: Mon, 25 Aug 2025 11:59:51 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: John Garry <john.g.garry@...cle.com>
Cc: "Martin K. Petersen" <martin.petersen@...cle.com>, <liuqiangneo@....com>,
        <James.Bottomley@...senPartnership.com>, <linux-scsi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Qiang Liu
 <liuqiang@...inos.cn>
Subject: Re: [PATCH] scsi: aic94xx: remove self-assigned redundant code


John,

>>> Assigning ssp_task.retry_count to itself has no effect
>> 
>>>   	scb->ssp_task.data_dir = data_dir_flags[task->data_dir];
>>> -	scb->ssp_task.retry_count = scb->ssp_task.retry_count;
>> This begs the question of what the original author intended to
>> write.

[...]

Applied to 6.18/scsi-staging, thanks!

-- 
Martin K. Petersen