linux-kernel - Re: [PATCH 05/16] gpio: pl061: Use modern PM macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VfauP9=fkoZd8D-kGOXye_uE8TE0k47YTogPDSk18gDNA@mail.gmail.com>
Date: Thu, 21 Aug 2025 15:50:07 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Jisheng Zhang <jszhang@...nel.org>, Doug Berger <opendmb@...il.com>, 
	Florian Fainelli <florian.fainelli@...adcom.com>, Bartosz Golaszewski <brgl@...ev.pl>, 
	Michael Buesch <m@...s.ch>, Hoan Tran <hoan@...amperecomputing.com>, 
	Andy Shevchenko <andy@...nel.org>, Daniel Palmer <daniel@...ngy.jp>, 
	Romain Perier <romain.perier@...il.com>, Grygorii Strashko <grygorii.strashko@...com>, 
	Santosh Shilimkar <ssantosh@...nel.org>, Kevin Hilman <khilman@...nel.org>, 
	Robert Jarzmik <robert.jarzmik@...e.fr>, Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>, 
	Masami Hiramatsu <mhiramat@...nel.org>, Shubhrajyoti Datta <shubhrajyoti.datta@....com>, 
	Srinivas Neeli <srinivas.neeli@....com>, Michal Simek <michal.simek@....com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, linux-gpio@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	linux-omap@...r.kernel.org, linux@...tq-group.com
Subject: Re: [PATCH 05/16] gpio: pl061: Use modern PM macros

On Thu, Aug 21, 2025 at 2:52 PM Linus Walleij <linus.walleij@...aro.org> wrote:
> On Wed, Aug 20, 2025 at 5:58 PM Jisheng Zhang <jszhang@...nel.org> wrote:

...

> > The pl061_context_save_regs structure is always embedded into struct
> > pl061 to simplify code, so this brings a tiny 8 bytes memory overhead
> > for !CONFIG_PM_SLEP.
> >
> > Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
>
> Hm true, 8 bytes is not a big deal.

It's better to double check. This data is per GPIO chip, the Q is how
many chips can be present on one system. Then the calculus will be N *
8 bytes.

Knowing gpio-dwapb (and having even a HW with it) the commit message
(there) seems like a slight manipulation as it doesn't clarify this
detail.

-- 
With Best Regards,
Andy Shevchenko