linux-kernel - Re: [PATCH 05/16] gpio: pl061: Use modern PM macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYQLqDxh=zqrZ+wK_Ky2wD5AUoVLmCV_JDfmaqJC4Yzqg@mail.gmail.com>
Date: Thu, 21 Aug 2025 13:52:05 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Jisheng Zhang <jszhang@...nel.org>
Cc: Doug Berger <opendmb@...il.com>, Florian Fainelli <florian.fainelli@...adcom.com>, 
	Bartosz Golaszewski <brgl@...ev.pl>, Michael Buesch <m@...s.ch>, Hoan Tran <hoan@...amperecomputing.com>, 
	Andy Shevchenko <andy@...nel.org>, Daniel Palmer <daniel@...ngy.jp>, 
	Romain Perier <romain.perier@...il.com>, Grygorii Strashko <grygorii.strashko@...com>, 
	Santosh Shilimkar <ssantosh@...nel.org>, Kevin Hilman <khilman@...nel.org>, 
	Robert Jarzmik <robert.jarzmik@...e.fr>, Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>, 
	Masami Hiramatsu <mhiramat@...nel.org>, Shubhrajyoti Datta <shubhrajyoti.datta@....com>, 
	Srinivas Neeli <srinivas.neeli@....com>, Michal Simek <michal.simek@....com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, linux-gpio@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	linux-omap@...r.kernel.org, linux@...tq-group.com
Subject: Re: [PATCH 05/16] gpio: pl061: Use modern PM macros

On Wed, Aug 20, 2025 at 5:58 PM Jisheng Zhang <jszhang@...nel.org> wrote:

> Use the modern PM macros for the suspend and resume functions to be
> automatically dropped by the compiler when CONFIG_PM or
> CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards.
>
> This has the advantage of always compiling these functions in,
> independently of any Kconfig option. Thanks to that, bugs and other
> regressions are subsequently easier to catch.
>
> The pl061_context_save_regs structure is always embedded into struct
> pl061 to simplify code, so this brings a tiny 8 bytes memory overhead
> for !CONFIG_PM_SLEP.
>
> Signed-off-by: Jisheng Zhang <jszhang@...nel.org>

Hm true, 8 bytes is not a big deal.

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij