[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8e9936e5-d720-4ded-8961-b9475aeb2ac7@web.de>
Date: Thu, 21 Aug 2025 18:28:14 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
linux-pci@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>
Cc: stable@...r.kernel.org, tudor.ambarus@...aro.org,
LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org,
Christian König <christian.koenig@....com>,
D Scott Phillips <scott@...amperecomputing.com>,
Krzysztof Wilczyński <kw@...ux.com>, Rio Liu <rio@....me>
Subject: Re: [PATCH v2 1/3] PCI: Relaxed tail alignment should never increase
min_align
…
> Ensure min_align is not increased by the relaxed tail alignment.
…
…
+++ b/drivers/pci/setup-bus.c
…
@@ -1261,8 +1263,9 @@ static int pbus_size_mem(struct pci_bus *bus, unsigned long mask,
if (bus->self && size1 &&
!pbus_upstream_space_available(bus, mask | IORESOURCE_PREFETCH, type,
size1, add_align)) {
- min_align = 1ULL << (max_order + __ffs(SZ_1M));
- min_align = max(min_align, win_align);
+ relaxed_align = 1ULL << (max_order + __ffs(SZ_1M));
+ relaxed_align = max(min_align, win_align);
…
I wonder why a variable content would be overwritten here
without using the previous value.
https://cwe.mitre.org/data/definitions/563.html
Regards,
Markus
Powered by blists - more mailing lists