linux-kernel - Re: [PATCH v5 3/4] gpu: nova-core: avoid probing non-display/compute PCI functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <753aa207-a2ed-4836-9525-5fbf68aff6ef@nvidia.com>
Date: Thu, 21 Aug 2025 09:54:41 -0700
From: John Hubbard <jhubbard@...dia.com>
To: Danilo Krummrich <dakr@...nel.org>
Cc: Alexandre Courbot <acourbot@...dia.com>,
 Joel Fernandes <joelagnelf@...dia.com>, Timur Tabi <ttabi@...dia.com>,
 Alistair Popple <apopple@...dia.com>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Krzysztof Wilczyński <kwilczynski@...nel.org>,
 Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
 nouveau@...ts.freedesktop.org, linux-pci@...r.kernel.org,
 rust-for-linux@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Elle Rhumsaa <elle@...thered-steel.dev>
Subject: Re: [PATCH v5 3/4] gpu: nova-core: avoid probing non-display/compute
 PCI functions

On 8/21/25 3:52 AM, Danilo Krummrich wrote:
> On Thu Aug 21, 2025 at 6:42 AM CEST, John Hubbard wrote:
>> NovaCore has so far been too imprecise about figuring out if .probe()
>> has found a supported PCI PF (Physical Function). By that I mean:
>> .probe() sets up BAR0 (which involves a lot of very careful devres and
>> Device<Bound> details behind the scenes). And then if it is dealing with
>> a non-supported device such as the .1 audio PF on many GPUs, it fails
>> out due to an unexpected BAR0 size. We have been fortunate that the BAR0
>> sizes are different.
>>
>> Really, we should be filtering on PCI class ID instead. These days I
>> think we can confidently pick out Nova's supported PF's via PCI class
>> ID. And if not, then we'll revisit.
>>
>> The approach here is to filter on "Display VGA" or "Display 3D", which
>> is how PCI class IDs express "this is a modern GPU's PF".
>>
>> Cc: Danilo Krummrich <dakr@...nel.org>
>> Cc: Alexandre Courbot <acourbot@...dia.com>
>> Cc: Elle Rhumsaa <elle@...thered-steel.dev>
>> Signed-off-by: John Hubbard <jhubbard@...dia.com>
>> ---
>>   drivers/gpu/nova-core/driver.rs | 33 ++++++++++++++++++++++++++++-----
>>   rust/kernel/pci.rs              | 21 +++++++++++++++++++++
> 
> Can you please split this one up in two patches?

Sure.

> 
>>   2 files changed, 49 insertions(+), 5 deletions(-)

thanks,
-- 
John Hubbard