linux-kernel - Re: [PATCH v5 1/4] rust: pci: provide access to PCI Class and Class-related items

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f718170b-8ad0-4039-a6d4-45eb067d02ff@nvidia.com>
Date: Thu, 21 Aug 2025 09:54:25 -0700
From: John Hubbard <jhubbard@...dia.com>
To: Danilo Krummrich <dakr@...nel.org>
Cc: Alexandre Courbot <acourbot@...dia.com>,
 Joel Fernandes <joelagnelf@...dia.com>, Timur Tabi <ttabi@...dia.com>,
 Alistair Popple <apopple@...dia.com>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Krzysztof Wilczyński <kwilczynski@...nel.org>,
 Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
 nouveau@...ts.freedesktop.org, linux-pci@...r.kernel.org,
 rust-for-linux@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Elle Rhumsaa <elle@...thered-steel.dev>
Subject: Re: [PATCH v5 1/4] rust: pci: provide access to PCI Class and
 Class-related items

On 8/21/25 3:51 AM, Danilo Krummrich wrote:
> On Thu Aug 21, 2025 at 6:42 AM CEST, John Hubbard wrote:
>> Allow callers to write Class::STORAGE_SCSI instead of
>> bindings::PCI_CLASS_STORAGE_SCSI, for example.
>>
>> New APIs:
>>      Class::STORAGE_SCSI, Class::NETWORK_ETHERNET, etc.
>>      Class::as_raw()
>>      Class: From<u32> for Class
>>      ClassMask: Full, ClassSubclass
>>      Device::pci_class()
>>
>> Cc: Danilo Krummrich <dakr@...nel.org>
>> Cc: Alexandre Courbot <acourbot@...dia.com>
>> Cc: Elle Rhumsaa <elle@...thered-steel.dev>
>> Signed-off-by: John Hubbard <jhubbard@...dia.com>
>> ---
>>   rust/kernel/pci.rs    |  10 ++
>>   rust/kernel/pci/id.rs | 239 ++++++++++++++++++++++++++++++++++++++++++
> 
> Please add rust/kernel/pci/ to the maintainers entry.

OK.

> 
> (Would have done on apply, but I have another comment on patch 3.)
> 
>>   2 files changed, 249 insertions(+)
>>   create mode 100644 rust/kernel/pci/id.rs

thanks,
-- 
John Hubbard