Message-ID: <20250821-haziness-squeamish-81713e94d079@spud>
Date: Thu, 21 Aug 2025 19:06:48 +0100
From: Conor Dooley <conor@...nel.org>
To: Marilene Andrade Garcia <marilene.agarcia@...il.com>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Marcelo Schmitt <marcelo.schmitt1@...il.com>,
	Marcelo Schmitt <Marcelo.Schmitt@...log.com>,
	Ceclan Dumitru <dumitru.ceclan@...log.com>,
	Jonathan Santos <Jonathan.Santos@...log.com>,
	Dragos Bogdan <dragos.bogdan@...log.com>,
	Kim Seer Paller <kimseer.paller@...log.com>
Subject: Re: [PATCH v1 0/2] Add MAX14001/MAX14002 support

On Thu, Aug 21, 2025 at 10:36:06AM -0300, Marilene Andrade Garcia wrote:
> Hello maintainers,
> 
> This patch series adds basic support for the Analog Devices 
> MAX14001/MAX14002, configurable, isolated 10-bit ADCs for multi-range 
> binary inputs. Besides the implemented ADC readings, these devices have 
> more features, like a binary comparator; a filtered reading that can 
> provide the average of the last 2, 4, or 8 ADC readings; and an inrush 
> comparator that triggers the inrush current. There is also a fault feature 
> that can diagnose seven possible fault conditions. 
> 
> To keep the commits simple and organized, these initial driver support 
> patches aim to upstream only the features related to reading two registers, 
> one that contains the latest ADC reading, and another one that contains 
> the latest filtered ADC readings. Though, _raw and _mean_raw are providing 
> the same results in this initial version since the data averaging config 
> interface is not implemented yet. For this, IIO_CHAN_INFO_AVERAGE_RAW was 
> used to return the filtered average of ADC readings. An additional patch 
> documenting the in_voltageY_mean_raw interface can be added on v2 if that 
> would be desirable. The idea is to use in_voltageY_mean_raw to return the 
> filtered average value, and also to set how many ADC readings (0, 2, 4, 
> or 8) are included in the mean calculation. I would also like to know if 
> you have any feedback on using IIO_CHAN_INFO_AVERAGE_RAW in this way.
> 
> The changes were tested using the Raspberry Pi modified kernel version 
> rpi-6.6 on Raspberry Pi 5 hardware. For testing, the MAX14001PMB evaluation 
> board was used, which contains two MAX14001 devices. According to the 
> board’s circuit configuration, one device measures current and the other 
> measures voltage. Due to the evaluation board’s circuitry, the devices 
> also receive an offset that allows them to measure negative values. None 
> of these evaluation board-specific characteristics were included in the 
> driver code (neither the offset nor the current channel capability). 
> However, they were considered in the calculation of the values read by the 
> devices. Should the code that applies these board configuration parameters 
> be added as an additional driver file inside the IIO subsystem, or should 
> it remain only in a user application file?
> 
> The code was developed during the GSoC program as part of the Analog 
> Devices Mentorship. Many thanks to my mentors Marcelo Schmitt,  Ceclan 
> Dumitru, Jonathan Santos and Dragos Bogdan for their guidance, reviews, 
> and explanations about the IIO subsystem code.
> 
> I intend to keep sending patches to cover all the features of the device.

Something gone wrong here? There's already a v9 from another ADI
employee on the list:
https://lore.kernel.org/all/20230710042723.46084-2-kimseer.paller@analog.com/

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)

Powered by blists - more mailing lists