linux-kernel - RE: [PATCH 2/4] remoteproc: imx_rproc: Populate devices under "rpmsg" subnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB918572D8E2C4C085E4D8E43C8932A@PAXPR04MB9185.eurprd04.prod.outlook.com>
Date: Thu, 21 Aug 2025 18:51:12 +0000
From: Shenwei Wang <shenwei.wang@....com>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>
CC: Bjorn Andersson <andersson@...nel.org>, Mathieu Poirier
	<mathieu.poirier@...aro.org>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Shawn Guo
	<shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Linus Walleij
	<linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, Pengutronix
 Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, Peng
 Fan <peng.fan@....com>, "linux-remoteproc@...r.kernel.org"
	<linux-remoteproc@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH 2/4] remoteproc: imx_rproc: Populate devices under "rpmsg"
 subnode



> -----Original Message-----
> From: Peng Fan (OSS) <peng.fan@....nxp.com>
> Sent: Thursday, August 21, 2025 6:03 AM
> To: Shenwei Wang <shenwei.wang@....com>
> Cc: Bjorn Andersson <andersson@...nel.org>; Mathieu Poirier
> <mathieu.poirier@...aro.org>; Rob Herring <robh@...nel.org>; Krzysztof
> Kozlowski <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; Shawn
> Guo <shawnguo@...nel.org>; Sascha Hauer <s.hauer@...gutronix.de>; Linus
> Walleij <linus.walleij@...aro.org>; Bartosz Golaszewski <brgl@...ev.pl>;
> Pengutronix Kernel Team <kernel@...gutronix.de>; Fabio Estevam
> <festevam@...il.com>; Peng Fan <peng.fan@....com>; linux-
> remoteproc@...r.kernel.org; devicetree@...r.kernel.org; imx@...ts.linux.dev;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; dl-linux-imx
> <linux-imx@....com>
> Subject: Re: [PATCH 2/4] remoteproc: imx_rproc: Populate devices under
> "rpmsg" subnode
> >
> > #include "imx_rproc.h"
> >@@ -1084,6 +1088,126 @@ static int imx_rproc_sys_off_handler(struct
> sys_off_data *data)
> > 	return NOTIFY_DONE;
> > }
> >
> 
> Just wonder could the changes be moved to drivers/rpmsg?

Since the DTS node is under imx_rproc, the most straightforward approach is to implement the 
feature here. Moving the implementation to drivers/rpmsg would introduce additional complexity
and might be less direct.

Thanks,
Shenwei

> 
> >+struct imx_rpmsg_driver {
> >+	struct rpmsg_driver rpdrv;
> >+	void *driver_data;
> >+};
> >+
> >+	i = drvdata->map_idx;
> >+	if (i >= ARRAY_SIZE(channel_device_map))
> >+		return -ENODEV;
> >+
> >+	auxdata = devm_kzalloc(dev, sizeof(*auxdata)*2, GFP_KERNEL);
> >+	if (!auxdata)
> >+		return -ENOMEM;
> >+
> >+	u8 major;
> >+	u8 minor;
> >+	u8 type;
> >+	u8 cmd;
> >+	u8 reserved[5];
> >+} __packed;
> 
> A comment should be added to describe each member.
> 
> Regards,
> Peng