linux-kernel - Re: [PATCH v4 2/6] watchdog: rzv2h: Obtain clock-divider and timeout values from OF match data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39eec996-87f7-48c9-b177-1b1e4a467f35@roeck-us.net>
Date: Wed, 20 Aug 2025 20:50:46 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Prabhakar <prabhakar.csengg@...il.com>,
 Wim Van Sebroeck <wim@...ux-watchdog.org>, Rob Herring <robh@...nel.org>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>,
 Magnus Damm <magnus.damm@...il.com>,
 Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc: linux-watchdog@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
 Biju Das <biju.das.jz@...renesas.com>,
 Fabrizio Castro <fabrizio.castro.jz@...esas.com>,
 Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v4 2/6] watchdog: rzv2h: Obtain clock-divider and timeout
 values from OF match data

On 8/20/25 13:23, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> 
> Update the rzv2h_wdt driver to fetch clock configuration and timeout
> parameters from device tree match data rather than relying on hardcoded
> constants. Introduce a new structure rzv2h_of_data that encapsulates
> minimum and maximum clock select values (cks_min and cks_max), clock
> divider (cks_div), timeout cycle count (timeout_cycles), and the
> timeout period select bits (tops). These values are provided through
> the OF match table and retrieved via of_device_get_match_data() during
> probe.
> 
> This change allows dynamic configuration of the watchdog timer for
> different SoCs, such as the RZ/T2H, which require different settings.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> Reviewed-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>