linux-kernel - Re: [PATCH v2 4/8] selftests/mm: Add -Wunused family of flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250821151308.915362b14e82f5626f659481@linux-foundation.org>
Date: Thu, 21 Aug 2025 15:13:08 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>
Cc: Kevin Brodsky <kevin.brodsky@....com>, kernel@...labora.com,
 linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org, Vlastimil
 Babka <vbabka@...e.cz>, Albert Ou <aou@...s.berkeley.edu>, Zi Yan
 <ziy@...dia.com>, David Hildenbrand <david@...hat.com>, Suren Baghdasaryan
 <surenb@...gle.com>, "Liam R. Howlett" <Liam.Howlett@...cle.com>, Baolin
 Wang <baolin.wang@...ux.alibaba.com>, Mike Rapoport <rppt@...nel.org>,
 Peter Xu <peterx@...hat.com>, Jason Gunthorpe <jgg@...pe.ca>, Palmer
 Dabbelt <palmer@...belt.com>, Ryan Roberts <ryan.roberts@....com>, Leon
 Romanovsky <leon@...nel.org>, Shuah Khan <shuah@...nel.org>, Lorenzo
 Stoakes <lorenzo.stoakes@...cle.com>, Alexandre Ghiti <alex@...ti.fr>,
 Barry Song <baohua@...nel.org>, Dev Jain <dev.jain@....com>,
 linux-kselftest@...r.kernel.org, Paul Walmsley <paul.walmsley@...ive.com>,
 linux-mm@...ck.org, Nico Pache <npache@...hat.com>, John Hubbard
 <jhubbard@...dia.com>, Michal Hocko <mhocko@...e.com>
Subject: Re: [PATCH v2 4/8] selftests/mm: Add -Wunused family of flags

On Thu, 21 Aug 2025 17:31:21 +0500 Muhammad Usama Anjum <usama.anjum@...labora.com> wrote:

> > My
> > feeling is that unused parameters are expected to be allowed in the
> > kernel and it isn't helpful to go against that expectation in just a
> > small subset of kselftests.
> I thought kernel must be giving error for unused parameters as well (from
> my memory). But just checked and it doesn't seem like it. I'm okay with
> dropping -Wunused-parameters.
> 
> We need to drop patch 6/7 and in Patch 4 should have only:
> 
> -CFLAGS += -Wunused  -Wunused-parameter -Wunused-function -Wunused-label -Wunused-variable -Wunused-value
> +CFLAGS += -Wunused
> 
> @Andrew, Should I resend the entire series or would you can make the change?

I think a new series would be clearer, please.  It's unclear (to me)
whether Kevin's various comments have all been addressed.