linux-kernel - Re: [PATCH v2 0/4] irqchip/sg2042-msi: Fix broken affinity setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <MAUPR01MB1107244E647EC28C7E7020EBBFE32A@MAUPR01MB11072.INDPRD01.PROD.OUTLOOK.COM>
Date: Thu, 21 Aug 2025 14:38:53 +0800
From: Chen Wang <unicorn_wang@...look.com>
To: Inochi Amaoto <inochiama@...il.com>, Thomas Gleixner
 <tglx@...utronix.de>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Marc Zyngier <maz@...nel.org>, Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Shradha Gupta <shradhagupta@...ux.microsoft.com>,
 Haiyang Zhang <haiyangz@...rosoft.com>,
 Jonathan Cameron <Jonathan.Cameron@...ei.com>,
 Juergen Gross <jgross@...e.com>, Nicolin Chen <nicolinc@...dia.com>,
 Jason Gunthorpe <jgg@...pe.ca>
Cc: linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
 Yixun Lan <dlan@...too.org>, Longbin Li <looong.bin@...il.com>
Subject: Re: [PATCH v2 0/4] irqchip/sg2042-msi: Fix broken affinity setting


On 8/14/2025 7:28 AM, Inochi Amaoto wrote:
> When using NVME on SG2044, the NVME always complains "I/O tag XXX
> (XXX) QID XX timeout, completion polled", which is caused by the
> broken handler of the sg2042-msi driver.
>
> As PLIC driver can only setting affinity when enabling, the sg2042-msi
> does not properly handled affinity setting previously and enable irq in
> an unexpected executing path.
>
> Add irq_startup/irq_shutdown support to the PCI template domain,
> then set irq_chip_[startup/shutdown]_parent for irq_startup/
> irq_shutdown of the sg2042-msi driver. So the irq can be started
> properly.
>
> Change from v1:
> 1. patch 1: Fix comment format problem, and structure the changelog.
> 2. patch 2: Improve the comment title and body, add describtion about
>              the fact the PLIC is used as parent chip.
> 3. patch 2: Remove __always_inline for cond_[shutdown/startup]_parent().
> 4. patch 3: Update the align of the "XXX_MSI_FLAGS_XXX" macro.
> 5. patch 4: Claim the fact that the added flag is used by the negotiation
>              of MSI controller driver and PCIe device driver, and can be
> 	    only used when both of them support this flag.
>
> Inochi Amaoto (4):
>    genirq: Add irq_chip_(startup/shutdown)_parent()
>    PCI/MSI: Add startup/shutdown for per device domains
>    irqchip/sg2042-msi: Fix broken affinity setting
>    irqchip/sg2042-msi: Set MSI_FLAG_MULTI_PCI_MSI flags for SG2044
>
>   drivers/irqchip/irq-sg2042-msi.c | 19 +++++++++---
>   drivers/pci/msi/irqdomain.c      | 52 ++++++++++++++++++++++++++++++++
>   include/linux/irq.h              |  2 ++
>   include/linux/msi.h              |  2 ++
>   kernel/irq/chip.c                | 37 +++++++++++++++++++++++
>   5 files changed, 107 insertions(+), 5 deletions(-)
>
> --
> 2.50.1
Reviewed-by: Chen Wang <unicorn_wang@...look.com>

It is recommended to add the following email link about the relevant 
discussion in the commit message for quich reference when there is a 
revision or merge:

https://lore.kernel.org/lkml/20250722224513.22125-1-inochiama@gmail.com/

Tested-by: Chen Wang <unicorn_wang@...look.com> # Pioneerbox