linux-kernel - Re: [PATCH v6] dt-bindings: firmware: arm,scmi: allow multiple instances

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a59908c9-38d8-492d-9e3f-5560d272689b@linaro.org>
Date: Thu, 21 Aug 2025 10:29:00 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Cristian Marussi <cristian.marussi@....com>,
 Deepti Jaggi <quic_djaggi@...cinc.com>
Cc: Sudeep Holla <sudeep.holla@....com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, arm-scmi@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel@....qualcomm.com,
 Nikunj Kela <quic_nkela@...cinc.com>
Subject: Re: [PATCH v6] dt-bindings: firmware: arm,scmi: allow multiple
 instances

On 21/08/2025 10:04, Cristian Marussi wrote:
> On Wed, Aug 20, 2025 at 11:44:26AM -0700, Deepti Jaggi wrote:
>>
>> On 7/30/25 14:30, Deepti Jaggi wrote:
>>> From: Nikunj Kela <quic_nkela@...cinc.com>
>>>
> 
> Hi,
> 
>>> Allow multiple SCMI instances by extending the scmi node name to include
>>> an instance number suffix.
>>>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>> Reviewed-by: Cristian Marussi <cristian.marussi@....com>
>>> Signed-off-by: Nikunj Kela <quic_nkela@...cinc.com>
>>> Signed-off-by: Deepti Jaggi <quic_djaggi@...cinc.com>
>>> ---
>>> Changes in v6:
>>>          - Dropped 'this change' from description
>>> 	- Link to v5: https://lore.kernel.org/all/20250423005824.3993256-1-quic_djaggi@quicinc.com
>>>
>>> Changes in v5:
>>>          - Added Reviewed-by tag
>>> 	- Link to v4: https://lore.kernel.org/all/20240910163456.2383372-1-quic_nkela@quicinc.com
>>>
>>> Changes in v4:
>>>          - Dropped 'virtual' from subject and description
>>> 	- Link to v3: https://lore.kernel.org/all/20240905201217.3815113-1-quic_nkela@quicinc.com
>>>
>>> Changes in v3:
>>>          - Added Reviewed-by tag
>>>          - Removed the patch from original series[1]
>>>
>>> Changes in v2:
>>>          - Fixed scmi nodename pattern
>>>
>>> [1]: https://lore.kernel.org/all/20240903220240.2594102-1-quic_nkela@quicinc.com/
>>> ---
>>>   Documentation/devicetree/bindings/firmware/arm,scmi.yaml | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
>>> index abbd62f1fed0993ab98fa44bdb9a0575f8e1c78e..be817fd9cc34b14009a3b1d69e78b802215571b6 100644
>>> --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
>>> +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
>>> @@ -27,7 +27,7 @@ anyOf:
>>>   properties:
>>>     $nodename:
>>> -    const: scmi
>>> +    pattern: '^scmi(-[0-9]+)?$'
>>>     compatible:
>>>       oneOf:
>>>
>>> ---
>>> base-commit: 0b90c3b6d76ea512dc3dac8fb30215e175b0019a
>>> change-id: 20250728-8255-scmi-ed963ef8f155
>>
>> Gentle ping!!

You cannot ping gently while screaming!!! (you see how gentle this feels?)

>> Could you please review the patch?
>>
> 
> I thought this was already reviewed/acked and merged since ages....
> ...also the wording-change in the commit message LGTM.
> 
> Reviewed-by: Cristian Marussi <cristian.marussi@....com>

It was. Twice! This is just unjustified ping.

Best regards,
Krzysztof