linux-kernel - Re: [RFC PATCH 05/17] verification/rvgen: Annotate DA functions with types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aac621d698dbb38458a1e701f0d177c6110f5447.camel@redhat.com>
Date: Thu, 21 Aug 2025 10:51:02 +0200
From: Gabriele Monaco <gmonaco@...hat.com>
To: Nam Cao <namcao@...utronix.de>
Cc: linux-kernel@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>, 
	linux-trace-kernel@...r.kernel.org, Tomas Glozar <tglozar@...hat.com>, Juri
 Lelli <jlelli@...hat.com>, Clark Williams <williams@...hat.com>, John Kacur
 <jkacur@...hat.com>
Subject: Re: [RFC PATCH 05/17] verification/rvgen: Annotate DA functions
 with types

On Thu, 2025-08-21 at 10:29 +0200, Nam Cao wrote:
> On Thu, Aug 14, 2025 at 05:07:57PM +0200, Gabriele Monaco wrote:
> > Functions in automata.py, dot2c.py and dot2k.py don't have type
> > annotations and it can get complicated to remember how to use them.
> > 
> > Add minimal type annotations.
> 
> Nice, Python is sometimes hard to read because the type is not clear.
> 
> > -    def __get_event_variables(self):
> > +    def __get_event_variables(self) -> tuple[list[str],
> > list[str]]:
> 
> This annotation is wrong. It becomes correct only after your later
> patch
> (verification/rvgen: Add support for Hybrid Automata)

Mmh, good point, that happened after I moved all cleanup patches before
the main changes (this was done after). I'm going to fix that.

Thanks,
Gabriele