linux-kernel - Re: [PATCH v2 6/9] drm/stm/dw_mipi_dsi-stm: convert from round_rate() to determine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea6b8999-4f5d-4cc2-b92b-b0776c2b1363@foss.st.com>
Date: Thu, 21 Aug 2025 11:35:24 +0200
From: Yannick FERTRE <yannick.fertre@...s.st.com>
To: Brian Masney <bmasney@...hat.com>, Philipp Zabel <p.zabel@...gutronix.de>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard
	<mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie
	<airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
        Shawn Guo
	<shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        "Pengutronix
 Kernel Team" <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Clark
	<robin.clark@....qualcomm.com>,
        Dmitry Baryshkov <lumag@...nel.org>,
        "Abhinav
 Kumar" <abhinav.kumar@...ux.dev>,
        Jessica Zhang
	<jessica.zhang@....qualcomm.com>,
        Sean Paul <sean@...rly.run>,
        Marijn Suijten
	<marijn.suijten@...ainline.org>,
        Raphael Gallais-Pou
	<raphael.gallais-pou@...s.st.com>,
        Philippe Cornu
	<philippe.cornu@...s.st.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Chen-Yu Tsai
	<wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Samuel Holland
	<samuel@...lland.org>, Stephen Boyd <sboyd@...nel.org>
CC: <linux-clk@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <imx@...ts.linux.dev>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <freedreno@...ts.freedesktop.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-sunxi@...ts.linux.dev>
Subject: Re: [PATCH v2 6/9] drm/stm/dw_mipi_dsi-stm: convert from round_rate()
 to determine_rate()

Hi Brian,

thanks for the patch.

Acked-by: Yannick Fertre <yannick.fertre@...s.st.com>

Le 11/08/2025 à 12:56, Brian Masney a écrit :
> The round_rate() clk ops is deprecated, so migrate this driver from
> round_rate() to determine_rate() using the Coccinelle semantic patch
> on the cover letter of this series.
>
> Acked-by: Raphael Gallais-Pou <raphael.gallais-pou@...s.st.com>
> Signed-off-by: Brian Masney <bmasney@...hat.com>
> ---
>   drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 14 ++++++++------
>   1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> index 2c7bc064bc66c6a58903a207cbe8091a14231c2b..58eae6804cc82d174323744206be7046568b905c 100644
> --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> @@ -274,8 +274,8 @@ static unsigned long dw_mipi_dsi_clk_recalc_rate(struct clk_hw *hw,
>   	return (unsigned long)pll_out_khz * 1000;
>   }
>   
> -static long dw_mipi_dsi_clk_round_rate(struct clk_hw *hw, unsigned long rate,
> -				       unsigned long *parent_rate)
> +static int dw_mipi_dsi_clk_determine_rate(struct clk_hw *hw,
> +					  struct clk_rate_request *req)
>   {
>   	struct dw_mipi_dsi_stm *dsi = clk_to_dw_mipi_dsi_stm(hw);
>   	unsigned int idf, ndiv, odf, pll_in_khz, pll_out_khz;
> @@ -283,14 +283,14 @@ static long dw_mipi_dsi_clk_round_rate(struct clk_hw *hw, unsigned long rate,
>   
>   	DRM_DEBUG_DRIVER("\n");
>   
> -	pll_in_khz = (unsigned int)(*parent_rate / 1000);
> +	pll_in_khz = (unsigned int)(req->best_parent_rate / 1000);
>   
>   	/* Compute best pll parameters */
>   	idf = 0;
>   	ndiv = 0;
>   	odf = 0;
>   
> -	ret = dsi_pll_get_params(dsi, pll_in_khz, rate / 1000,
> +	ret = dsi_pll_get_params(dsi, pll_in_khz, req->rate / 1000,
>   				 &idf, &ndiv, &odf);
>   	if (ret)
>   		DRM_WARN("Warning dsi_pll_get_params(): bad params\n");
> @@ -298,7 +298,9 @@ static long dw_mipi_dsi_clk_round_rate(struct clk_hw *hw, unsigned long rate,
>   	/* Get the adjusted pll out value */
>   	pll_out_khz = dsi_pll_get_clkout_khz(pll_in_khz, idf, ndiv, odf);
>   
> -	return pll_out_khz * 1000;
> +	req->rate = pll_out_khz * 1000;
> +
> +	return 0;
>   }
>   
>   static int dw_mipi_dsi_clk_set_rate(struct clk_hw *hw, unsigned long rate,
> @@ -351,7 +353,7 @@ static const struct clk_ops dw_mipi_dsi_stm_clk_ops = {
>   	.disable = dw_mipi_dsi_clk_disable,
>   	.is_enabled = dw_mipi_dsi_clk_is_enabled,
>   	.recalc_rate = dw_mipi_dsi_clk_recalc_rate,
> -	.round_rate = dw_mipi_dsi_clk_round_rate,
> +	.determine_rate = dw_mipi_dsi_clk_determine_rate,
>   	.set_rate = dw_mipi_dsi_clk_set_rate,
>   };
>   
>