linux-kernel - Re: [PATCH v2 7/9] drm/stm/lvds: convert from round_rate() to determine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86adb9ce-68de-494f-92e8-6e11773987fe@foss.st.com>
Date: Thu, 21 Aug 2025 11:36:13 +0200
From: Yannick FERTRE <yannick.fertre@...s.st.com>
To: Brian Masney <bmasney@...hat.com>, Philipp Zabel <p.zabel@...gutronix.de>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard
	<mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie
	<airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
        Shawn Guo
	<shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        "Pengutronix
 Kernel Team" <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Clark
	<robin.clark@....qualcomm.com>,
        Dmitry Baryshkov <lumag@...nel.org>,
        "Abhinav
 Kumar" <abhinav.kumar@...ux.dev>,
        Jessica Zhang
	<jessica.zhang@....qualcomm.com>,
        Sean Paul <sean@...rly.run>,
        Marijn Suijten
	<marijn.suijten@...ainline.org>,
        Raphael Gallais-Pou
	<raphael.gallais-pou@...s.st.com>,
        Philippe Cornu
	<philippe.cornu@...s.st.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Chen-Yu Tsai
	<wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Samuel Holland
	<samuel@...lland.org>, Stephen Boyd <sboyd@...nel.org>
CC: <linux-clk@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <imx@...ts.linux.dev>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <freedreno@...ts.freedesktop.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-sunxi@...ts.linux.dev>
Subject: Re: [PATCH v2 7/9] drm/stm/lvds: convert from round_rate() to
 determine_rate()

Hi Brian,

thanks for the patch.

Acked-by: Yannick Fertre <yannick.fertre@...s.st.com>

Le 11/08/2025 à 12:56, Brian Masney a écrit :
> The round_rate() clk ops is deprecated, so migrate this driver from
> round_rate() to determine_rate() using the Coccinelle semantic patch
> on the cover letter of this series.
>
> Acked-by: Raphael Gallais-Pou <raphael.gallais-pou@...s.st.com>
> Signed-off-by: Brian Masney <bmasney@...hat.com>
> ---
>   drivers/gpu/drm/stm/lvds.c | 12 +++++++-----
>   1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/lvds.c b/drivers/gpu/drm/stm/lvds.c
> index 07788e8d3d8302a3951e97d64736b721033998d3..fe38c0984b2b552e1ccaef4d1e589b9d86a40ee3 100644
> --- a/drivers/gpu/drm/stm/lvds.c
> +++ b/drivers/gpu/drm/stm/lvds.c
> @@ -682,8 +682,8 @@ static unsigned long lvds_pixel_clk_recalc_rate(struct clk_hw *hw,
>   	return (unsigned long)lvds->pixel_clock_rate;
>   }
>   
> -static long lvds_pixel_clk_round_rate(struct clk_hw *hw, unsigned long rate,
> -				      unsigned long *parent_rate)
> +static int lvds_pixel_clk_determine_rate(struct clk_hw *hw,
> +					 struct clk_rate_request *req)
>   {
>   	struct stm_lvds *lvds = container_of(hw, struct stm_lvds, lvds_ck_px);
>   	unsigned int pll_in_khz, bdiv = 0, mdiv = 0, ndiv = 0;
> @@ -703,7 +703,7 @@ static long lvds_pixel_clk_round_rate(struct clk_hw *hw, unsigned long rate,
>   	mode = list_first_entry(&connector->modes,
>   				struct drm_display_mode, head);
>   
> -	pll_in_khz = (unsigned int)(*parent_rate / 1000);
> +	pll_in_khz = (unsigned int)(req->best_parent_rate / 1000);
>   
>   	if (lvds_is_dual_link(lvds->link_type))
>   		multiplier = 2;
> @@ -719,14 +719,16 @@ static long lvds_pixel_clk_round_rate(struct clk_hw *hw, unsigned long rate,
>   	lvds->pixel_clock_rate = (unsigned long)pll_get_clkout_khz(pll_in_khz, bdiv, mdiv, ndiv)
>   					 * 1000 * multiplier / 7;
>   
> -	return lvds->pixel_clock_rate;
> +	req->rate = lvds->pixel_clock_rate;
> +
> +	return 0;
>   }
>   
>   static const struct clk_ops lvds_pixel_clk_ops = {
>   	.enable = lvds_pixel_clk_enable,
>   	.disable = lvds_pixel_clk_disable,
>   	.recalc_rate = lvds_pixel_clk_recalc_rate,
> -	.round_rate = lvds_pixel_clk_round_rate,
> +	.determine_rate = lvds_pixel_clk_determine_rate,
>   };
>   
>   static const struct clk_init_data clk_data = {
>