linux-kernel - Re: [PATCH net] microchip: lan865x: fix missing ndo_eth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <204b8b3d-e981-41fa-b65c-46b012742bfe@lunn.ch>
Date: Fri, 22 Aug 2025 02:17:32 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Parthiban Veerasooran <parthiban.veerasooran@...rochip.com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] microchip: lan865x: fix missing ndo_eth_ioctl
 handler to support PHY ioctl

On Thu, Aug 21, 2025 at 01:58:32PM +0530, Parthiban Veerasooran wrote:
> The LAN865x Ethernet driver is missing an .ndo_eth_ioctl implementation,
> which is required to handle standard MII ioctl commands such as
> SIOCGMIIREG and SIOCSMIIREG. These commands are used by userspace tools
> (e.g., ethtool, mii-tool) to access and configure PHY registers.
> 
> This patch adds the lan865x_eth_ioctl() function to pass ioctl calls to
> the PHY layer via phy_mii_ioctl() when the interface is up.
> 
> Without this handler, MII ioctl operations return -EINVAL, breaking PHY
> diagnostics and configuration from userspace.

I'm not sure this classes as a fix. This IOCTL is optional, not
mandatory. Returning EINVAL is valid behaviour. So for me, this is
just ongoing development work, adding more features to the driver.

Please submit to net-next.

    Andrew

---
pw-bot: cr