linux-kernel - Re: [PATCH net] microchip: lan865x: fix missing ndo_eth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4a2e6ca1-7ae9-4959-a394-c84aab4b4c02@microchip.com>
Date: Fri, 22 Aug 2025 04:24:36 +0000
From: <Parthiban.Veerasooran@...rochip.com>
To: <andrew@...n.ch>
CC: <andrew+netdev@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] microchip: lan865x: fix missing ndo_eth_ioctl handler
 to support PHY ioctl

Hi Andrew,

Thank you for reviewing this patch.

On 22/08/25 5:47 am, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Thu, Aug 21, 2025 at 01:58:32PM +0530, Parthiban Veerasooran wrote:
>> The LAN865x Ethernet driver is missing an .ndo_eth_ioctl implementation,
>> which is required to handle standard MII ioctl commands such as
>> SIOCGMIIREG and SIOCSMIIREG. These commands are used by userspace tools
>> (e.g., ethtool, mii-tool) to access and configure PHY registers.
>>
>> This patch adds the lan865x_eth_ioctl() function to pass ioctl calls to
>> the PHY layer via phy_mii_ioctl() when the interface is up.
>>
>> Without this handler, MII ioctl operations return -EINVAL, breaking PHY
>> diagnostics and configuration from userspace.
> 
> I'm not sure this classes as a fix. This IOCTL is optional, not
> mandatory. Returning EINVAL is valid behaviour. So for me, this is
> just ongoing development work, adding more features to the driver.
> 
> Please submit to net-next.
Sure I will submit it to net-next as it is a feature.

By the way, is there a possibility to submit or apply this patch to the 
older stable kernels as well, so that users on those versions can also 
benefit from this feature?

Best regards,
Parthiban V
> 
>      Andrew
> 
> ---
> pw-bot: cr