linux-kernel - Re: [PATCH v2 11/11] media: iris: Enable Secure PAS support with IOMMU managed by Linux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f25b6cb4-666d-e3e1-0540-b2d7fad86407@quicinc.com>
Date: Fri, 22 Aug 2025 09:56:49 +0530
From: Vikash Garodia <quic_vgarodia@...cinc.com>
To: Stephan Gerhold <stephan.gerhold@...aro.org>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>,
        "Dikshita
 Agarwal" <quic_dikshita@...cinc.com>,
        Mauro Carvalho Chehab
	<mchehab@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        "Abhinav
 Kumar" <abhinav.kumar@...ux.dev>,
        Bryan O'Donoghue
	<bryan.odonoghue@...aro.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-media@...r.kernel.org>, <linux-remoteproc@...r.kernel.org>
Subject: Re: [PATCH v2 11/11] media: iris: Enable Secure PAS support with
 IOMMU managed by Linux


On 8/20/2025 7:09 PM, Stephan Gerhold wrote:
>>>> +int iris_fw_init(struct iris_core *core)
>>>> +{
>>>> +	struct platform_device_info info;
>>>> +	struct iommu_domain *iommu_dom;
>>>> +	struct platform_device *pdev;
>>>> +	struct device_node *np;
>>>> +	int ret;
>>>> +
>>>> +	np = of_get_child_by_name(core->dev->of_node, "video-firmware");
>>>> +	if (!np)
>>>> +		return 0;
>>> You need a dt-bindings change for this as well. This is documented only
>>> for Venus.
>> You are right, wanted to send device tree and binding support separately.
>> But if required, will add with the series in the next version.
>>
> You can send device tree changes separately, but dt-binding changes
> always need to come before the driver changes.

Do you mean to update the examples section[1] with the firmware subnode,
something similar to venus schema[2] ?

Regards,
Vikash

[1]
https://elixir.bootlin.com/linux/v6.17-rc2/source/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml#L109

[2]
https://elixir.bootlin.com/linux/v6.17-rc2/source/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml#L128