linux-kernel - Re: [PATCH] serial: 8250_core: fix coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac753910-ff9f-42d6-aaad-74ccecfef681@kernel.org>
Date: Fri, 22 Aug 2025 06:30:50 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Osama Abdelkader <osama.abdelkader@...il.com>,
 gregkh@...uxfoundation.org, ilpo.jarvinen@...ux.intel.com, mingo@...nel.org,
 john.ogness@...utronix.de, tglx@...utronix.de
Cc: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH] serial: 8250_core: fix coding style issues

On 21. 08. 25, 19:58, Osama Abdelkader wrote:
> Fix a few coding style issues in 8250_core.c:
> 
> - Remove redundant NULL initialization of a global pointer
> - Add missing blank line after a variable declaration
> 
> Signed-off-by: Osama Abdelkader <osama.abdelkader@...il.com>
> ---
>   drivers/tty/serial/8250/8250_core.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index feb920c5b2e8..0d1d2eed2a5c 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -307,7 +307,7 @@ static void univ8250_release_irq(struct uart_8250_port *up)
>   		serial_unlink_irq_chain(up);
>   }
>   
> -const struct uart_ops *univ8250_port_base_ops = NULL;
> +const struct uart_ops *univ8250_port_base_ops;
>   struct uart_ops univ8250_port_ops;
>   
>   static const struct uart_8250_ops univ8250_driver_ops = {
> @@ -773,6 +773,7 @@ int serial8250_register_8250_port(const struct uart_8250_port *up)
>   	 */
>   	if (!has_acpi_companion(uart->port.dev)) {
>   		struct mctrl_gpios *gpios = mctrl_gpio_init(&uart->port, 0);
> +
>   		if (IS_ERR(gpios)) {

NACK to this one. It's a declaration with an initializer and the 'if' 
checks its value.

>   			ret = PTR_ERR(gpios);
>   			goto err;


-- 
js
suse labs