linux-kernel - Re: [Intel-wired-lan] [PATCH net] i40e: Prevent unwanted interface name changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0f19e779-ec78-419a-a261-c4550d778b45@molgen.mpg.de>
Date: Fri, 22 Aug 2025 08:31:51 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Calvin Owens <calvin@...nvd.org>
Cc: netdev@...r.kernel.org, Tony Nguyen <anthony.l.nguyen@...el.com>,
 Przemek Kitszel <przemyslaw.kitszel@...el.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Jedrzej Jagielski <jedrzej.jagielski@...el.com>,
 Ivan Vecera <ivecera@...hat.com>, intel-wired-lan@...ts.osuosl.org,
 linux-kernel@...r.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH net] i40e: Prevent unwanted interface
 name changes

Dear Calvin,

Thank you for your patch..

Am 20.08.25 um 06:29 schrieb Calvin Owens:
> The same naming regression which was reported in ixgbe and fixed in
> commit e67a0bc3ed4f ("ixgbe: prevent from unwanted interface name
> changes") still exists in i40e.
> 
> Fix i40e by setting the same flag, added in commit c5ec7f49b480
> ("devlink: let driver opt out of automatic phys_port_name generation").
> 
> Fixes: 9e479d64dc58 ("i40e: Add initial devlink support")
> Signed-off-by: Calvin Owens <calvin@...nvd.org>
> ---
>   drivers/net/ethernet/intel/i40e/i40e_devlink.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_devlink.c b/drivers/net/ethernet/intel/i40e/i40e_devlink.c
> index cc4e9e2addb7..40f81e798151 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_devlink.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_devlink.c
> @@ -212,6 +212,7 @@ int i40e_devlink_create_port(struct i40e_pf *pf)
>   
>   	attrs.flavour = DEVLINK_PORT_FLAVOUR_PHYSICAL;
>   	attrs.phys.port_number = pf->hw.pf_id;
> +	attrs.no_phys_port_name = 1;
>   	i40e_devlink_set_switch_id(pf, &attrs.switch_id);
>   	devlink_port_attrs_set(&pf->devlink_port, &attrs);
>   	err = devlink_port_register(devlink, &pf->devlink_port, pf->hw.pf_id);

Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>

Kind regards,

Paul