linux-kernel - Re: [PATCH v2] dt-bindings: mfd: Move embedded controllers to own directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbLKXx7GEOPemFGSTFy8oDG99TUFwC7sH7xkaoqe-cY8A@mail.gmail.com>
Date: Fri, 22 Aug 2025 11:22:49 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Benson Leung <bleung@...omium.org>, 
	Guenter Roeck <groeck@...omium.org>, Tim Harvey <tharvey@...eworks.com>, 
	Michael Walle <mwalle@...nel.org>, Bartosz Golaszewski <brgl@...ev.pl>, Jean Delvare <jdelvare@...e.com>, 
	Thomas Gleixner <tglx@...utronix.de>, Lee Jones <lee@...nel.org>, 
	Uwe Kleine-König <ukleinek@...nel.org>, 
	Bjorn Andersson <andersson@...nel.org>, Mathieu Poirier <mathieu.poirier@...aro.org>, 
	Matthias Brugger <matthias.bgg@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
	Cheng-Yi Chiang <cychiang@...omium.org>, Tzung-Bi Shih <tzungbi@...nel.org>, 
	Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, 
	Wim Van Sebroeck <wim@...ux-watchdog.org>, Thierry Reding <thierry.reding@...il.com>, 
	Tinghan Shen <tinghan.shen@...iatek.com>, devicetree@...r.kernel.org, 
	chrome-platform@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	linux-gpio@...r.kernel.org, linux-hwmon@...r.kernel.org, 
	linux-pwm@...r.kernel.org, linux-remoteproc@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, 
	linux-sound@...r.kernel.org, linux-watchdog@...r.kernel.org, 
	Mathew McBride <matt@...verse.com.au>
Subject: Re: [PATCH v2] dt-bindings: mfd: Move embedded controllers to own directory

On Fri, Aug 22, 2025 at 9:57 AM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:

> Move ChromeOS Embedded Controller, Gateworks System Controller and
> Kontron sl28cpld Board Management Controller to new subdirectory
> "embedded-controller" matching their purpose.  MFD is coming from Linux
> and does not really fit the actual purpose of this hardware.
>
> Rename Gateworks GSC filename to match compatible, as preferred for
> bindings.

Maybe add some definition of what we mean with "embedded controller"?

Something like:

"An embedded controller is a discrete component that contains a
microcontroller (i.e. a small CPU running a small firmware without
operating system) mounted into a larger computer system running
a fully fledged operating system that needs to utilize the embedded
controller as part of its operation."

> Acked-by: Michael Walle <mwalle@...nel.org> # for sl28cpld
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Overall this looks reasonable:
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij