linux-kernel - Re: [PATCH 10/33] arm_mpam: Add probe/remove for mpam msc driver and kbuild boiler plate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025082328-acorn-wound-5c3d@gregkh>
Date: Sat, 23 Aug 2025 08:41:34 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: James Morse <james.morse@....com>, linux-arm-kernel@...ts.infradead.org,
	linux-acpi@...r.kernel.org, devicetree@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Amit Singh Tomar <amitsinght@...vell.com>,
	Baisheng Gao <baisheng.gao@...soc.com>,
	Baolin Wang <baolin.wang@...ux.alibaba.com>,
	bobo.shaobowang@...wei.com,
	Carl Worth <carl@...amperecomputing.com>,
	Catalin Marinas <catalin.marinas@....com>,
	Conor Dooley <conor+dt@...nel.org>,
	Danilo Krummrich <dakr@...nel.org>,
	Dave Martin <Dave.Martin@....com>,
	David Hildenbrand <david@...hat.com>,
	Drew Fustini <dfustini@...libre.com>,
	D Scott Phillips <scott@...amperecomputing.com>,
	Fenghua Yu <fenghuay@...dia.com>, Hanjun Guo <guohanjun@...wei.com>,
	Jamie Iles <quic_jiles@...cinc.com>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Koba Ko <kobak@...dia.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Len Brown <lenb@...nel.org>, Linu Cherian <lcherian@...vell.com>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Peter Newman <peternewman@...gle.com>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Rex Nie <rex.nie@...uarmicro.com>, Rob Herring <robh@...nel.org>,
	Rohit Mathew <rohit.mathew@....com>,
	Shameer Kolothum <shameerali.kolothum.thodi@...wei.com>,
	Shanker Donthineni <sdonthineni@...dia.com>,
	Shaopeng Tan <tan.shaopeng@...itsu.com>,
	Sudeep Holla <sudeep.holla@....com>, Will Deacon <will@...nel.org>,
	Xin Hao <xhao@...ux.alibaba.com>
Subject: Re: [PATCH 10/33] arm_mpam: Add probe/remove for mpam msc driver and
 kbuild boiler plate

On Fri, Aug 22, 2025 at 09:55:33PM +0200, Markus Elfring wrote:
> …
> …
> > +static int mpam_msc_drv_probe(struct platform_device *pdev)
> > +{
> …
> > +	} while (0);
> > +	mutex_unlock(&mpam_list_lock);
> > +
> > +	if (!err) {
> > +		/* Create RIS entries described by firmware */
> > +		if (!acpi_disabled)
> > +			err = acpi_mpam_parse_resources(msc, plat_data);
> > +		else
> > +			err = mpam_dt_parse_resources(msc, plat_data);
> > +	}
> > +
> > +	if (!err && fw_num_msc == mpam_num_msc)
> > +		mpam_discovery_complete();
> > +
> > +	if (err && msc)
> > +		mpam_msc_drv_remove(pdev);
> > +
> > +	return err;
> > +}
> …
> 
> * Would you like to integrate anything from the following source code variant?
> 
> 	if (!err)
> 		/* Create RIS entries described by firmware */
> 		err = acpi_disabled
> 		      ? mpam_dt_parse_resources(msc, plat_data)
> 		      : acpi_mpam_parse_resources(msc, plat_data);
> 
> 	if (err) {
> 		if (msc)
> 			mpam_msc_drv_remove(pdev);
> 	} else {
> 		if (fw_num_msc == mpam_num_msc)
> 			mpam_discovery_complete();
> 	}
> 
> * How do you think about to increase the application of scope-based resource management
>   at further places?
> 
> 
> Regards,
> Markus

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot