linux-kernel - Re: [PATCH v2 2/2] cgroup/psi: Set of->priv to NULL upon file release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025082322-canopener-snugness-14e3@gregkh>
Date: Sat, 23 Aug 2025 08:43:48 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Tejun Heo <tj@...nel.org>
Cc: Chen Ridong <chenridong@...weicloud.com>, hannes@...xchg.org,
	mkoutny@...e.com, peterz@...radead.org, zhouchengming@...edance.com,
	linux-kernel@...r.kernel.org, cgroups@...r.kernel.org,
	lujialin4@...wei.com, chenridong@...wei.com, libaokun1@...wei.com
Subject: Re: [PATCH v2 2/2] cgroup/psi: Set of->priv to NULL upon file release

On Fri, Aug 22, 2025 at 07:48:08AM -1000, Tejun Heo wrote:
> On Fri, Aug 22, 2025 at 07:07:15AM +0000, Chen Ridong wrote:
> > From: Chen Ridong <chenridong@...wei.com>
> > 
> > Setting of->priv to NULL when the file is released enables earlier bug
> > detection. This allows potential bugs to manifest as NULL pointer
> > dereferences rather than use-after-free errors[1], which are generally more
> > difficult to diagnose.
> > 
> > [1] https://lore.kernel.org/cgroups/38ef3ff9-b380-44f0-9315-8b3714b0948d@huaweicloud.com/T/#m8a3b3f88f0ff3da5925d342e90043394f8b2091b
> > Signed-off-by: Chen Ridong <chenridong@...wei.com>
> 
> Applied to cgroup/for-6.17-fixes.

Both or just this second patch?  Should I take the first through the
driver-core tree, or do you want to take it through the cgroup tree?  No
objection from me for you to take both :)

thanks,

greg k-h