linux-kernel - Re: [PATCH 2/2] arm64: dts: marvell: armada-cp11x: Add default ICU address cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ee241506-96a1-431e-a7a7-2e5848fce0e0@linaro.org>
Date: Sat, 23 Aug 2025 10:47:09 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Andrew Lunn <andrew@...n.ch>,
 Gregory Clement <gregory.clement@...tlin.com>,
 Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-arm-kernel@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: marvell: armada-cp11x: Add default ICU
 address cells

On 22/08/2025 15:33, Krzysztof Kozlowski wrote:
> Add missing address-cells 0 to the ICU interrupt node to silence W=1
> warning:
> 
>   armada-cp11x.dtsi:547.3-47: Warning (interrupt_map): /cp0-bus/pcie@...00000:interrupt-map:
>     Missing property '#address-cells' in node /cp0-bus/bus@...00000/interrupt-controller@...000/interrupt-controller@10, using 0 as fallback
> 
> Value '0' is correct because:
> 1. GIC interrupt controller does not have children,
> 2. interrupt-map property (in PCI node) consists of five components and
>    the fourth component "parent unit address", which size is defined by
>    '#address-cells' of the node pointed to by the interrupt-parent
>    component, is not used (=0)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  arch/arm64/boot/dts/marvell/armada-cp11x.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> index a057e119492f..d9d409eac259 100644
> --- a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> @@ -202,6 +202,7 @@ CP11X_LABEL(icu): interrupt-controller@...000 {
>  			CP11X_LABEL(icu_nsr): interrupt-controller@10 {
>  				compatible = "marvell,cp110-icu-nsr";
>  				reg = <0x10 0x20>;
> +				#address-cells = <0>;
This is not GIC, so it might need bindings adjustment. LKP reported:

interrupt-controller@...000 (marvell,cp110-icu):
interrupt-controller@10: '#address-cells' does not match any of the
regexes: '^pinctrl-[0-9]+$'

Best regards,
Krzysztof