linux-kernel - Re: [PATCH v3 2/2] drm: bridge: Add TI tmds181 and sn65dp159 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <127919d3-6b6f-4845-9356-72b9558ca991@kernel.org>
Date: Sat, 23 Aug 2025 10:50:34 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Mike Looijmans <mike.looijmans@...ic.nl>
Cc: dri-devel@...ts.freedesktop.org, Andrzej Hajda <andrzej.hajda@...el.com>,
 David Airlie <airlied@...il.com>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Jonas Karlman <jonas@...boo.se>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>,
 Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>,
 Simona Vetter <simona@...ll.ch>, Thomas Zimmermann <tzimmermann@...e.de>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] drm: bridge: Add TI tmds181 and sn65dp159 driver

On 22/08/2025 17:16, Mike Looijmans wrote:
>>> +
>>> +static struct i2c_driver tmds181_driver = {
>>> +	.driver = {
>>> +		.owner = THIS_MODULE,
>> Nice coincidence - this stars in one of my talks on OSSE
>> (https://sched.co/25VoV) as my litmus test for crazy old, vendor code.
>> Please come to the session if you are around or just check the slides
>> afterwards.
> 
> Oh, Amsterdam this year. Hadn't spotted that in time, or I would have 
> been there!
> 
> I added coccinelle to my toolkit (would make a good addition to patman). 
> Indeed would have prevented the old-skool I2C stuff that I've been 
> lugging along in drivers for a decade...
> 
> I'll fix those in v4.
> 
> And yeah, the real issue is that I didn't submit this driver seven years 
> ago. In my defense, the other guys also didn't.
> 
> For your talk, maybe add a tip on how to avoid the verbose output.
> make C=1 CHECK=scripts/coccicheck drivers/gpu/drm/bridge/ti-tmds181.o
> I get a gazillion lines of "/usr/bin/spatch -D report ..." and it's 
> difficult to spot the warnings. Tried adding "V=0" but that didn't make 
> a difference, piping through "grep :" helped a bundle.

make coccicheck M=drivers/gpu/drm/bridge/ DEBUG_FILE=cocci.err



Best regards,
Krzysztof