linux-kernel - Re: [PATCH v2 1/4] dt-bindings: iio: adc: ad7768-1: add new supported parts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <510f6efb-ada3-4848-ac8e-16fa5d1b5284@kernel.org>
Date: Sun, 24 Aug 2025 13:20:21 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jonathan Santos <Jonathan.Santos@...log.com>,
 linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org
Cc: Michael.Hennerich@...log.com, lars@...afoo.de, jic23@...nel.org,
 dlechner@...libre.com, nuno.sa@...log.com, andy@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, marcelo.schmitt1@...il.com
Subject: Re: [PATCH v2 1/4] dt-bindings: iio: adc: ad7768-1: add new supported
 parts

On 24/08/2025 06:09, Jonathan Santos wrote:
> Add compatibles for supported parts in the ad7768-1 family:
> 	ADAQ7767-1, ADAQ7768-1 and ADAQ7769-1
> 
> Add property and checks for AAF gain, supported by ADAQ7767-1
> and ADAQ7769-1 parts:
> 	adi,gain-milli
> 
> Signed-off-by: Jonathan Santos <Jonathan.Santos@...log.com>

git send-email v2*

Not patch by patch. You made it very difficult for us to review and to
apply.

> ---
> v2 Changes:
> * adi,aaf-gain property renamed to adi,gain-milli. Description was 
>   simplified.
> * default value add to adi,gain-milli.
> ---
>  .../bindings/iio/adc/adi,ad7768-1.yaml        | 43 +++++++++++++++++--
>  1 file changed, 39 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml
> index c06d0fc791d3..0c39491f6179 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml
> @@ -4,18 +4,26 @@
>  $id: http://devicetree.org/schemas/iio/adc/adi,ad7768-1.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Analog Devices AD7768-1 ADC device driver
> +title: Analog Devices AD7768-1 ADC family
>  
>  maintainers:
>    - Michael Hennerich <michael.hennerich@...log.com>
>  
>  description: |
> -  Datasheet at:
> -    https://www.analog.com/media/en/technical-documentation/data-sheets/ad7768-1.pdf
> +  Analog Devices AD7768-1 24-Bit Single Channel Low Power sigma-delta ADC family
> +
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/ad7768-1.pdf
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/adaq7767-1.pdf
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/adaq7768-1.pdf
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/adaq7769-1.pdf
>  
>  properties:
>    compatible:
> -    const: adi,ad7768-1
> +    enum:
> +      - adi,ad7768-1
> +      - adi,adaq7767-1
> +      - adi,adaq7768-1
> +      - adi,adaq7769-1
>  
>    reg:
>      maxItems: 1
> @@ -58,6 +66,18 @@ properties:
>      description:
>        ADC reference voltage supply
>  
> +  adi,gain-milli:
> +    description: |
> +       Specifies the gain applied by the Analog Anti-Aliasing Filter (AAF) to the
> +       ADC input (in milli units). The hardware gain is determined by which input


I don't think there is no such thing as "milli units". milli is SI
prefix, not unit. So "units" is the unit? Or how exactly?

Basis points were before since 2022 so I don't get why these other
bindings introduced in 2024 could not use it?

Anyway, if you ever do not apply reviewers comment, then your commit msg
should explain this. Otherwise you get the same discussion here.

Best regards,
Krzysztof