linux-kernel - Re: [PATCH v2] dt-bindings: dma: img-mdc-dma: convert to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b748f86f-68ee-47fd-8394-f6352f99f3f0@kernel.org>
Date: Sun, 24 Aug 2025 13:24:02 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Nino Zhang <ninozhang001@...il.com>, devicetree@...r.kernel.org
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 vkoul@...nel.org, rahulbedarkar89@...il.com, linux-mips@...r.kernel.org,
 dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: dma: img-mdc-dma: convert to DT schema

On 24/08/2025 05:45, Nino Zhang wrote:
> Convert the img-mdc-dma binding from txt to YAML schema.
> No functional changes except dropping the consumer node
> (spi@...00f00) from the example, which belongs to the
> consumer binding instead.
> 
> Signed-off-by: Nino Zhang <ninozhang001@...il.com>
> ---
> Changes since v1:
> - All review comments addressed.

Do not attach (thread) your patchsets to some other threads (unrelated
or older versions). This buries them deep in the mailbox and might
interfere with applying entire sets.

> 
> Open:
> - Maintainers: set to Rahul Bedarkar + linux-mips per MAINTAINERS entry
>   for Pistachio/CI40 device tree. This seems the closest match to the
>   hardware. Happy to adjust if platform maintainers suggest otherwise.
> - img,max-burst-multiplier: defined as uint32. A minimum of 1 is used to
>   exclude the invalid case of 0, but the actual supported range has not
>   been confirmed in available documentation. Example uses 16. A maximum
>   will be added once confirmed by platform maintainers or hardware docs.
> 
>  .../bindings/dma/img,pistachio-mdc-dma.yaml   | 90 +++++++++++++++++++
>  .../devicetree/bindings/dma/img-mdc-dma.txt   | 57 ------------
>  2 files changed, 90 insertions(+), 57 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/dma/img,pistachio-mdc-dma.yaml
>  delete mode 100644 Documentation/devicetree/bindings/dma/img-mdc-dma.txt
> 
> diff --git a/Documentation/devicetree/bindings/dma/img,pistachio-mdc-dma.yaml b/Documentation/devicetree/bindings/dma/img,pistachio-mdc-dma.yaml
> new file mode 100644
> index 000000000000..4dde54a17f52
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/img,pistachio-mdc-dma.yaml
> @@ -0,0 +1,90 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/dma/img,pistachio-mdc-dma.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: IMG Multi-threaded DMA Controller (MDC)
> +
> +maintainers:
> +  - Rahul Bedarkar <rahulbedarkar89@...il.com>
> +  - linux-mips@...r.kernel.org
> +
> +allOf:
> +  - $ref: /schemas/dma/dma-controller.yaml#
> +
> +properties:
> +  compatible:
> +    const: img,pistachio-mdc-dma
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    minItems: 1
> +    maxItems: 32

Why is this flexible?

> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    items:
> +      - const: sys
> +
> +  img,cr-periph:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: >

Drop >

You already got exactly the same comment.


> +      Phandle to peripheral control syscon node with DMA request to channel
> +      mapping registers.
> +
> +  img,max-burst-multiplier:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 1

Does not feel like enough of constraints.

> +    description: >
> +      Maximum supported burst size multiplier. The maximum burst size is this
> +      value multiplied by the hardware-reported bus width.
> +
> +  "#dma-cells":
> +    const: 3
> +    description: |
> +      DMA specifier cells:
> +        1: peripheral's DMA request line
> +        2: channel bitmap: bit N set indicates channel N is usable
> +        3: thread ID to be used by the channel
> +
> +  dma-channels:
> +    $ref: /schemas/types.yaml#/definitions/uint32

More ignored comments.

Please go back to previous posting and respond to each comment. Then
implement each one or keep discussing.

Best regards,
Krzysztof