linux-kernel - Re: [PATCH v4 06/34] x86/cpuid: Introduce <asm/cpuid/leaf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250825141803.GUaKxwm1lAAugFJHVQ@fat_crate.local>
Date: Mon, 25 Aug 2025 16:18:03 +0200
From: Borislav Petkov <bp@...en8.de>
To: "Ahmed S. Darwish" <darwi@...utronix.de>
Cc: Ingo Molnar <mingo@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Cooper <andrew.cooper3@...rix.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Sean Christopherson <seanjc@...gle.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Sohil Mehta <sohil.mehta@...el.com>,
	John Ogness <john.ogness@...utronix.de>, x86@...nel.org,
	x86-cpuid@...ts.linux.dev, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 06/34] x86/cpuid: Introduce <asm/cpuid/leaf_types.h>

On Fri, Aug 15, 2025 at 09:01:59AM +0200, Ahmed S. Darwish wrote:
> +struct leaf_0x1_0 {
> +	// eax
> +	u32	stepping			:  4, // Stepping ID

All those bit names in all those leafs: are they taken from the official
documentation?

They should be.

...

> +/*
> + * Leaf 0x5
> + * MONITOR/MWAIT instructions enumeration
				 ^^^^^^^^^^^

Let's drop all those tautologies - it is absolutely clear that it is an
enumeration so no need for it. Just keep the minimum text that is needed to
describe the bit. People can always use that to find the official
documentation of they need more info.

...

> +/*
> + * Leaf 0x18
> + * Intel determenestic address translation (TLB) parameters

+ * Intel determenestic address translation (TLB) parameters
Unknown word [determenestic] in comment.
Suggestions: ['deterministic',...

spellchecker please.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette