linux-kernel - Re: [PATCH v2 3/3] irqchip/gic-v5: Fix error handling in gicv5_its_irq_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d04c798e-cce4-6e08-2632-0255d48b0564@huawei.com>
Date: Mon, 25 Aug 2025 11:54:56 +0800
From: Zenghui Yu <yuzenghui@...wei.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Lorenzo Pieralisi <lpieralisi@...nel.org>, Marc Zyngier <maz@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>, Sascha Bischoff
	<sascha.bischoff@....com>, Timothy Hayes <timothy.hayes@....com>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] irqchip/gic-v5: Fix error handling in
 gicv5_its_irq_domain_alloc()

On 2025/7/18 2:45, Dan Carpenter wrote:
> There are two issues to fix in this code:
> 1) If gicv5_alloc_lpi() fails the original code was checking the wrong
> variable.  Fix the mixup between "ret" and "lpi".
> 2) Clean up from all the previous iterations and not just the current
> iteration.
> 
> Fixes: 57d72196dfc8 ("irqchip/gic-v5: Add GICv5 ITS support")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
> v2: In v1 I had the wrong goto if gicv5_alloc_lpi() failed.  Also change
> the label name from out_free_lpi to out_free_irqs.
> 
>  drivers/irqchip/irq-gic-v5-its.c | 20 ++++++++++++++------
>  1 file changed, 14 insertions(+), 6 deletions(-)

Reviewed-by: Zenghui Yu <yuzenghui@...wei.com>