linux-kernel - Re: [PATCH v1 1/3] drivers: cpufreq: add Tegra 4 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2395520.irdbgypaU6@senjougahara>
Date: Mon, 25 Aug 2025 12:56:02 +0900
From: Mikko Perttunen <mperttunen@...dia.com>
To: Svyatoslav Ryhel <clamor95@...il.com>
Cc: Thierry Reding <thierry.reding@...il.com>,
 Jonathan Hunter <jonathanh@...dia.com>,
 Peter De Schrijver <pdeschrijver@...dia.com>,
 Prashant Gaikwad <pgaikwad@...dia.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>,
 Viresh Kumar <viresh.kumar@...aro.org>,
 Philipp Zabel <p.zabel@...gutronix.de>, linux-tegra@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
 linux-pm@...r.kernel.org
Subject: Re: [PATCH v1 1/3] drivers: cpufreq: add Tegra 4 support

On Friday, August 22, 2025 2:21 PM Svyatoslav Ryhel wrote:
> пт, 22 серп. 2025 р. о 05:58 Mikko Perttunen <mperttunen@...dia.com> пише:
> > On Friday, March 21, 2025 6:55 PM Svyatoslav Ryhel wrote:
> > > Tegra 4 is fully compatible with existing Tegra K1 cpufreq driver.
> > > 
> > > Signed-off-by: Svyatoslav Ryhel <clamor95@...il.com>
> > > ---
> > > 
> > >  drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
> > >  drivers/cpufreq/tegra124-cpufreq.c   | 5 +++--
> > >  2 files changed, 4 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c
> > > b/drivers/cpufreq/cpufreq-dt-platdev.c index 18942bfe9c95..7d15a1224d37
> > > 100644
> > > --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> > > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> > > @@ -140,6 +140,7 @@ static const struct of_device_id blocklist[]
> > > __initconst = {
> > > 
> > >       { .compatible = "nvidia,tegra20", },
> > >       { .compatible = "nvidia,tegra30", },
> > > 
> > > +     { .compatible = "nvidia,tegra114", },
> > > 
> > >       { .compatible = "nvidia,tegra124", },
> > >       { .compatible = "nvidia,tegra210", },
> > >       { .compatible = "nvidia,tegra234", },
> > > 
> > > diff --git a/drivers/cpufreq/tegra124-cpufreq.c
> > > b/drivers/cpufreq/tegra124-cpufreq.c index 514146d98bca..6ff2ccc08e5e
> > > 100644
> > > --- a/drivers/cpufreq/tegra124-cpufreq.c
> > > +++ b/drivers/cpufreq/tegra124-cpufreq.c
> > > @@ -189,8 +189,9 @@ static int __init tegra_cpufreq_init(void)
> > > 
> > >       int ret;
> > >       struct platform_device *pdev;
> > > 
> > > -     if (!(of_machine_is_compatible("nvidia,tegra124") ||
> > > -             of_machine_is_compatible("nvidia,tegra210")))
> > > +     if (!(of_machine_is_compatible("nvidia,tegra114") ||
> > > +           of_machine_is_compatible("nvidia,tegra124") ||
> > > +           of_machine_is_compatible("nvidia,tegra210")))
> > > 
> > >               return -ENODEV;
> > >       
> > >       /*
> > 
> > I also prefer using Tegra114 and Tegra124 in the commit message, perhaps
> > with the marketing names in parentheses, as the chip IDs are more
> > consistent and (IMO) easier to decipher than the product names.
> > 
> > Reviewed-by: Mikko Perttunen <mperttunen@...dia.com>
> 
> Yes, this was applied in v2 already and all other my Tegra patches,
> this exact commit was already picked from v2.

Ah, sorry. Not sure how I missed that.

Mikko