linux-kernel - Re: [PATCH v10] rust: transmute: Add methods for FromBytes trait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABm2a9fFR-qOApEX7MQ5s-MKeBCHbX_Ja3Dh_RybWBHONfa=kg@mail.gmail.com>
Date: Mon, 25 Aug 2025 15:51:30 -0300
From: Christian <christiansantoslima21@...il.com>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org, ~lkcamp/patches@...ts.sr.ht, 
	richard120310@...il.com
Subject: Re: [PATCH v10] rust: transmute: Add methods for FromBytes trait

Hi, Alice.

> Does the warning appear on all configurations? If so, this #[allow]
> should be an #[expect].

If clippy is disabled, nothing is reported.

> >  macro_rules! impl_frombytes {
> >      ($($({$($generics:tt)*})? $t:ty, )*) => {
> > @@ -28,7 +94,6 @@ macro_rules! impl_frombytes {
> >
> >      // SAFETY: If all bit patterns are acceptable for individual values in an array, then all bit
> >      // patterns are also acceptable for arrays of that type.
> > -    {<T: FromBytes>} [T],
>
> Why is this impl removed? I would think that with the Self: Sized
> bounds, you don't need to remove it anymore.

I interpreted too literally the idea of removing the implementation of slices.

Thanks,
Christian