linux-kernel - Re: [PATCH] uapi/fcntl: conditionally define AT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fc0b3998-df4a-49d0-88a6-e2c1c5c6650c@infradead.org>
Date: Mon, 25 Aug 2025 12:29:54 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Matthew Wilcox <willy@...radead.org>
Cc: linux-kernel@...r.kernel.org, Amir Goldstein <amir73il@...il.com>,
 Jeff Layton <jlayton@...nel.org>, Chuck Lever <chuck.lever@...cle.com>,
 Alexander Aring <alex.aring@...il.com>, Josef Bacik <josef@...icpanda.com>,
 Aleksa Sarai <cyphar@...har.com>, Jan Kara <jack@...e.cz>,
 Christian Brauner <brauner@...nel.org>, linux-fsdevel@...r.kernel.org,
 linux-api@...r.kernel.org
Subject: Re: [PATCH] uapi/fcntl: conditionally define AT_RENAME* macros



On 8/25/25 11:45 AM, Matthew Wilcox wrote:
> On Mon, Aug 25, 2025 at 10:52:31AM -0700, Randy Dunlap wrote:
>> $ grep -r AT_RENAME_NOREPLACE /usr/include
>> /usr/include/stdio.h:# define AT_RENAME_NOREPLACE RENAME_NOREPLACE
>> /usr/include/linux/fcntl.h:#define AT_RENAME_NOREPLACE	0x0001
>>
>> I have libc 2.42-1.1 (openSUSE).
> 
> I wonder if we can fix it by changing include/uapi/linux/fcntl.h
> from being an explicit 0x0001 to RENAME_NOREPLACE?  There's probably
> a horrendous include problem between linux/fcntl.h and linux/fs.h
> though?

I'm working on something like that now (suggested by Amir),
but it might depend on whether stdio.h has been #included first.

-- 
~Randy