linux-kernel - Re: [PATCH 2/7] iio: adc: Remove dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250825093622.68c8e5cc@jic23-huawei>
Date: Mon, 25 Aug 2025 09:36:22 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Cc: Xichao Zhao <zhao.xichao@...o.com>, Andreas Klinger <ak@...klinger.de>,
 David Lechner <dlechner@...libre.com>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>, Haibo Chen
 <haibo.chen@....com>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer
 <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Marius Cristea
 <marius.cristea@...rochip.com>, Neil Armstrong <neil.armstrong@...aro.org>,
 Kevin Hilman <khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>,
 Heiko Stuebner <heiko@...ech.de>, Francesco Dolcini <francesco@...cini.it>,
 João Paulo Gonçalves
 <jpaulo.silvagoncalves@...il.com>, Hugo Villeneuve
 <hvilleneuve@...onoff.com>, "open list:AVIA HX711 ANALOG DIGITAL CONVERTER
 IIO DRIVER" <linux-iio@...r.kernel.org>, open list
 <linux-kernel@...r.kernel.org>, "open list:NXP i.MX 7D/6SX/6UL/93 AND VF610
 ADC DRIVER" <imx@...ts.linux.dev>, "moderated list:ARM/FREESCALE IMX / MXC
 ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>, "open
 list:ARM/Amlogic Meson SoC support" <linux-amlogic@...ts.infradead.org>,
 "open list:ARM/Rockchip SoC support" <linux-rockchip@...ts.infradead.org>
Subject: Re: [PATCH 2/7] iio: adc: Remove dev_err_probe() if error is
 -ENOMEM

On Thu, 21 Aug 2025 22:31:51 +0200
Martin Blumenstingl <martin.blumenstingl@...glemail.com> wrote:

> On Thu, Aug 21, 2025 at 10:07 AM Xichao Zhao <zhao.xichao@...o.com> wrote:
> >
> > The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
> > Therefore, remove the useless call to dev_err_probe(), and just
> > return the value instead.
> >
> > Signed-off-by: Xichao Zhao <zhao.xichao@...o.com>
> > ---
> >  drivers/iio/adc/hx711.c           | 2 +-
> >  drivers/iio/adc/imx93_adc.c       | 3 +--
> >  drivers/iio/adc/mcp3564.c         | 2 +-
> >  drivers/iio/adc/meson_saradc.c    | 2 +-  
> For meson_saradc:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> 

Hi Martin (applies to others in this series),

For a comment about a tag please use the style submitting-patches suggests.
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com> # for meson_saradc

Then the tooling picks it automatically.  Sometimes I remember to edit commits
to tidy this up, but not always!

Jonathan