linux-kernel - Re: [PATCH 3/7] iio: chemical: Remove dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250825093733.789cfc12@jic23-huawei>
Date: Mon, 25 Aug 2025 09:37:33 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Gustavo Silva <gustavograzs@...il.com>
Cc: Xichao Zhao <zhao.xichao@...o.com>, David Lechner
 <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>, Andy
 Shevchenko <andy@...nel.org>, Tomasz Duszynski
 <tomasz.duszynski@...akon.com>, "open list:IIO SUBSYSTEM AND DRIVERS"
 <linux-iio@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/7] iio: chemical: Remove dev_err_probe() if error is
 -ENOMEM

On Sat, 23 Aug 2025 14:27:55 -0300
Gustavo Silva <gustavograzs@...il.com> wrote:

> On Thu, Aug 21, 2025 at 04:06:47PM +0800, Xichao Zhao wrote:
> > The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
> > Therefore, remove the useless call to dev_err_probe(), and just
> > return the value instead.
> > 
> > Signed-off-by: Xichao Zhao <zhao.xichao@...o.com>
> > ---
> >  drivers/iio/chemical/ens160_core.c | 3 +--
> >  drivers/iio/chemical/scd30_core.c  | 2 +-
> >  2 files changed, 2 insertions(+), 3 deletions(-)  
> For ens160:
> Reviewed-by: Gustavo Silva <gustavograzs@...il.com>

Please use
Reviewed-by: Gustavo Silva <gustavograzs@...il.com> # for ens160

for commented tags.  Then tooling should pick them up correctly
without me needing to hand edit.

Thanks,

Jonathan