linux-kernel - Re: [PATCH net-next v01 10/12] hinic3: Add Rss function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+D+mmGms5eYxntwpyd3OX1yXz3c9xvjQT_XmmnvxJGwg@mail.gmail.com>
Date: Tue, 26 Aug 2025 10:54:41 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: Fan Gong <gongfan1@...wei.com>
Cc: Zhu Yikai <zhuyikai1@...artners.com>, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Andrew Lunn <andrew+netdev@...n.ch>, linux-doc@...r.kernel.org, 
	Jonathan Corbet <corbet@....net>, Bjorn Helgaas <helgaas@...nel.org>, luosifu <luosifu@...wei.com>, 
	Xin Guo <guoxin09@...wei.com>, Shen Chenyang <shenchenyang1@...ilicon.com>, 
	Zhou Shuai <zhoushuai28@...wei.com>, Wu Like <wulike1@...wei.com>, 
	Shi Jing <shijing34@...wei.com>, Meny Yossefi <meny.yossefi@...wei.com>, 
	Gur Stavi <gur.stavi@...wei.com>, Lee Trager <lee@...ger.us>, 
	Michael Ellerman <mpe@...erman.id.au>, Vadim Fedorenko <vadim.fedorenko@...ux.dev>, 
	Suman Ghosh <sumang@...vell.com>, Przemek Kitszel <przemyslaw.kitszel@...el.com>, 
	Joe Damato <jdamato@...tly.com>, Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH net-next v01 10/12] hinic3: Add Rss function

On Tue, Aug 26, 2025 at 2:06 AM Fan Gong <gongfan1@...wei.com> wrote:
>
> Initialize rss functions. Configure rss hash data and HW resources.
>
> Co-developed-by: Xin Guo <guoxin09@...wei.com>
> Signed-off-by: Xin Guo <guoxin09@...wei.com>
> Co-developed-by: Zhu Yikai <zhuyikai1@...artners.com>
> Signed-off-by: Zhu Yikai <zhuyikai1@...artners.com>
> Signed-off-by: Fan Gong <gongfan1@...wei.com>
> ---

...

> +static int alloc_rss_resource(struct net_device *netdev)
> +{
> +       struct hinic3_nic_dev *nic_dev = netdev_priv(netdev);
> +       static const u8 default_rss_key[L2NIC_RSS_KEY_SIZE] = {
> +               0x6d, 0x5a, 0x56, 0xda, 0x25, 0x5b, 0x0e, 0xc2,
> +               0x41, 0x67, 0x25, 0x3d, 0x43, 0xa3, 0x8f, 0xb0,
> +               0xd0, 0xca, 0x2b, 0xcb, 0xae, 0x7b, 0x30, 0xb4,
> +               0x77, 0xcb, 0x2d, 0xa3, 0x80, 0x30, 0xf2, 0x0c,
> +               0x6a, 0x42, 0xb7, 0x3b, 0xbe, 0xac, 0x01, 0xfa};
> +
> +       nic_dev->rss_hkey = kzalloc(L2NIC_RSS_KEY_SIZE, GFP_KERNEL);
> +       if (!nic_dev->rss_hkey)
> +               return -ENOMEM;
> +
> +       memcpy(nic_dev->rss_hkey, default_rss_key, L2NIC_RSS_KEY_SIZE);

I think you need to explain why you are not using netdev_rss_key_fill()