linux-kernel - Re: [PATCH net-next v01 01/12] hinic3: HW initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0395d500-0b8e-4a2b-9dcd-d33df994f581@oracle.com>
Date: Wed, 27 Aug 2025 01:22:14 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: Fan Gong <gongfan1@...wei.com>, Zhu Yikai <zhuyikai1@...artners.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
        Andrew Lunn <andrew+netdev@...n.ch>, linux-doc@...r.kernel.org,
        Jonathan Corbet <corbet@....net>, Bjorn Helgaas <helgaas@...nel.org>,
        luosifu <luosifu@...wei.com>, Xin Guo <guoxin09@...wei.com>,
        Shen Chenyang <shenchenyang1@...ilicon.com>,
        Zhou Shuai <zhoushuai28@...wei.com>, Wu Like <wulike1@...wei.com>,
        Shi Jing <shijing34@...wei.com>,
        Meny Yossefi <meny.yossefi@...wei.com>,
        Gur Stavi <gur.stavi@...wei.com>, Lee Trager <lee@...ger.us>,
        Michael Ellerman <mpe@...erman.id.au>,
        Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
        Suman Ghosh
 <sumang@...vell.com>,
        Przemek Kitszel <przemyslaw.kitszel@...el.com>,
        Joe Damato <jdamato@...tly.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH net-next v01 01/12] hinic3: HW initialization


> +static int db_area_idx_init(struct hinic3_hwif *hwif, u64 db_base_phy,
> +			    u8 __iomem *db_base, u64 db_dwqe_len)
> +{
> +	struct hinic3_db_area *db_area = &hwif->db_area;
> +	u32 db_max_areas;
> +
> +	hwif->db_base_phy = db_base_phy;
> +	hwif->db_base = db_base;
> +	hwif->db_dwqe_len = db_dwqe_len;
> +
> +	db_max_areas = db_dwqe_len > HINIC3_DB_DWQE_SIZE ?
> +		       HINIC3_DB_MAX_AREAS : db_dwqe_len / HINIC3_DB_PAGE_SIZE;
> +	db_area->db_bitmap_array = bitmap_zalloc(db_max_areas, GFP_KERNEL);
> +	if (!db_area->db_bitmap_array)
> +		return -ENOMEM;
> +
> +	db_area->db_max_areas = db_max_areas;
> +	spin_lock_init(&db_area->idx_lock);
> +
> +	return 0;
> +}
> +
> +static void db_area_idx_free(struct hinic3_db_area *db_area)
> +{
> +	kfree(db_area->db_bitmap_array);

db_bitmap_array allocation was done via bitmap_zalloc().
is it ok to use kfree? or bitmap_free

> +}
> +
>   static int get_db_idx(struct hinic3_hwif *hwif, u32 *idx)
>   {
>   	struct hinic3_db_area *db_area = &hwif->db_area;
> @@ -125,6 +273,15 @@ void hinic3_set_msix_state(struct hinic3_hwdev *hwdev, u16 msix_idx,
>   	hinic3_hwif_write_reg(hwif, addr, mask_bits);
>   }
>   
[clip]
> diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_pci_id_tbl.h b/drivers/net/ethernet/huawei/hinic3/hinic3_pci_id_tbl.h
> new file mode 100644
> index 000000000000..7d60bd45ad1b
> --- /dev/null
> +++ b/drivers/net/ethernet/huawei/hinic3/hinic3_pci_id_tbl.h
> @@ -0,0 +1,10 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* Copyright (c) Huawei Technologies Co., Ltd. 2025. All rights reserved. */
> +
> +#ifndef _HINIC3_PCI_ID_TBL_H_
> +#define _HINIC3_PCI_ID_TBL_H_
> +
> +#define PCI_VENDOR_ID_HUAWEI    0x19e5

kernel already has PCI_VENDOR_ID_HUAWEI in <linux/pci_ids.h>

> +#define PCI_DEV_ID_HINIC3_VF    0x375F
> +
> +#endif
Thanks,
Alok