linux-kernel - Re: [PATCH v9 6/7] rust: time: Add Instant::from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87jz2qwl1z.fsf@t14s.mail-host-address-is-not-set>
Date: Tue, 26 Aug 2025 10:20:56 +0200
From: Andreas Hindborg <a.hindborg@...nel.org>
To: Alice Ryhl <aliceryhl@...gle.com>, Lyude Paul <lyude@...hat.com>
Cc: Boqun Feng <boqun.feng@...il.com>, FUJITA Tomonori
 <fujita.tomonori@...il.com>, Frederic Weisbecker <frederic@...nel.org>,
 Thomas Gleixner <tglx@...utronix.de>, Anna-Maria Behnsen
 <anna-maria@...utronix.de>, John Stultz <jstultz@...gle.com>, Stephen Boyd
 <sboyd@...nel.org>, Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor
 <alex.gaynor@...il.com>, Gary Guo <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, Benno Lossin <lossin@...nel.org>, Trevor
 Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>, "open
 list:DELAY, SLEEP, TIMEKEEPING, TIMERS [RUST]"
 <rust-for-linux@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v9 6/7] rust: time: Add Instant::from_ktime()

"Alice Ryhl" <aliceryhl@...gle.com> writes:

> On Thu, Aug 21, 2025 at 9:34 PM Lyude Paul <lyude@...hat.com> wrote:
>>

<cut>

>
>> +    #[inline]
>> +    pub(crate) unsafe fn from_ktime(ktime: bindings::ktime_t) -> Self {
>> +        debug_assert!(ktime >= 0);
>
> If you're going to have a debug assertion, perhaps it would make sense
> to check both bounds?

The upper bound is bindings::ktime_t::MAX, so it would be a useless check.


Best regards,
Andreas Hindborg