linux-kernel - Re: [PATCH next] media: ti: j721e-csi2rx: Fix NULL vs IS_ERR() bug in ti_csi2rx_request_max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <175630379558.1633224.13627427442522908758@freya>
Date: Wed, 27 Aug 2025 19:39:55 +0530
From: Jai Luthra <jai.luthra@...asonboard.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Jai Luthra <jai.luthra@...ux.dev>, Mauro Carvalho Chehab <mchehab@...nel.org>, Sakari Ailus <sakari.ailus@...ux.intel.com>, Hans Verkuil <hverkuil+cisco@...nel.org>, linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] media: ti: j721e-csi2rx: Fix NULL vs IS_ERR() bug in ti_csi2rx_request_max_ppc()

Hi Dan,

Quoting Dan Carpenter (2025-08-27 18:32:57)
> The media_entity_remote_source_pad_unique() function never returns NULL,
> it returns error pointers.  Change this check from a NULL check to an
> IS_ERR() check.
> 
> Fixes: 31f91c5224cd ("media: ti: j721e-csi2rx: Support multiple pixels per clock")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> index 3992f8b754b7..b75aa363d1bf 100644
> --- a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> +++ b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> @@ -497,7 +497,7 @@ static void ti_csi2rx_request_max_ppc(struct ti_csi2rx_dev *csi)
>         int ret;
>  
>         pad = media_entity_remote_source_pad_unique(&csi->vdev.entity);
> -       if (!pad)
> +       if (IS_ERR(pad))

Argh, my bad. Thanks for the quick fix.

Reviewed-by: Jai Luthra <jai.luthra@...asonboard.com>

>                 return;
>  
>         ret = cdns_csi2rx_negotiate_ppc(csi->source, pad->index, &ppc);
> -- 
> 2.47.2
>