[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <aK8CATf4EdcYcTe-@stanley.mountain>
Date: Wed, 27 Aug 2025 16:02:57 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Jai Luthra <jai.luthra@...asonboard.com>
Cc: Jai Luthra <jai.luthra@...ux.dev>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Hans Verkuil <hverkuil+cisco@...nel.org>,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org
Subject: [PATCH next] media: ti: j721e-csi2rx: Fix NULL vs IS_ERR() bug in
ti_csi2rx_request_max_ppc()
The media_entity_remote_source_pad_unique() function never returns NULL,
it returns error pointers. Change this check from a NULL check to an
IS_ERR() check.
Fixes: 31f91c5224cd ("media: ti: j721e-csi2rx: Support multiple pixels per clock")
Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
---
drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
index 3992f8b754b7..b75aa363d1bf 100644
--- a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
+++ b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
@@ -497,7 +497,7 @@ static void ti_csi2rx_request_max_ppc(struct ti_csi2rx_dev *csi)
int ret;
pad = media_entity_remote_source_pad_unique(&csi->vdev.entity);
- if (!pad)
+ if (IS_ERR(pad))
return;
ret = cdns_csi2rx_negotiate_ppc(csi->source, pad->index, &ppc);
--
2.47.2
Powered by blists - more mailing lists