linux-kernel - Re: [PATCH next] HID: i2c-hid: Fix test in i2c_hid_core_register_panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <r6q738p1-53o9-273q-0198-327s56qpqn61@xreary.bet>
Date: Wed, 27 Aug 2025 17:39:44 +0200 (CEST)
From: Jiri Kosina <jikos@...nel.org>
To: Doug Anderson <dianders@...omium.org>
cc: Dan Carpenter <dan.carpenter@...aro.org>, 
    Pin-yen Lin <treapking@...omium.org>, 
    Benjamin Tissoires <bentiss@...nel.org>, 
    Aleksandrs Vinarskis <alex.vinarskis@...il.com>, 
    Wentao Guan <guanwentao@...ontech.com>, 
    Bartłomiej Maryńczak <marynczakbartlomiej@...il.com>, 
    Dmitry Torokhov <dmitry.torokhov@...il.com>, Kenny Levinsen <kl@...wtf>, 
    linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, 
    kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] HID: i2c-hid: Fix test in
 i2c_hid_core_register_panel_follower()

On Wed, 27 Aug 2025, Doug Anderson wrote:

> > Bitwise AND was intended instead of OR.  With the current code the
> > condition is always true.
> >
> > Fixes: cbdd16b818ee ("HID: i2c-hid: Make elan touch controllers power on after panel is enabled")
> > Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> > ---
> >  drivers/hid/i2c-hid/i2c-hid-core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Douglas Anderson <dianders@...omium.org

This seems to be missing closing bracket :)

> Jiri / Benjamin: if one of you can give this a quick Ack then I'll
> throw it into drm-misc-next with the patch it's fixing.

Acked-by: Jiri Kosina <jkosina@...e.com>

Thanks!

-- 
Jiri Kosina
SUSE Labs