linux-kernel - Re: [PATCH next] HID: i2c-hid: Fix test in i2c_hid_core_register_panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=Vqp7zDi=xGmy+gq+jSr1Tq=bRAUbkOVuVcz7C9zFbWXQ@mail.gmail.com>
Date: Wed, 27 Aug 2025 16:38:35 -0700
From: Doug Anderson <dianders@...omium.org>
To: Jiri Kosina <jikos@...nel.org>
Cc: Dan Carpenter <dan.carpenter@...aro.org>, Pin-yen Lin <treapking@...omium.org>, 
	Benjamin Tissoires <bentiss@...nel.org>, Aleksandrs Vinarskis <alex.vinarskis@...il.com>, 
	Wentao Guan <guanwentao@...ontech.com>, 
	Bartłomiej Maryńczak <marynczakbartlomiej@...il.com>, 
	Dmitry Torokhov <dmitry.torokhov@...il.com>, Kenny Levinsen <kl@...wtf>, linux-input@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] HID: i2c-hid: Fix test in i2c_hid_core_register_panel_follower()

Hi,

On Wed, Aug 27, 2025 at 8:39 AM Jiri Kosina <jikos@...nel.org> wrote:
>
> On Wed, 27 Aug 2025, Doug Anderson wrote:
>
> > > Bitwise AND was intended instead of OR.  With the current code the
> > > condition is always true.
> > >
> > > Fixes: cbdd16b818ee ("HID: i2c-hid: Make elan touch controllers power on after panel is enabled")
> > > Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> > > ---
> > >  drivers/hid/i2c-hid/i2c-hid-core.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Reviewed-by: Douglas Anderson <dianders@...omium.org
>
> This seems to be missing closing bracket :)

Fixed. The tools would probably have caught it, but better to be safe.
...actually, "b4" fixed it for me. :-P

> > Jiri / Benjamin: if one of you can give this a quick Ack then I'll
> > throw it into drm-misc-next with the patch it's fixing.
>
> Acked-by: Jiri Kosina <jkosina@...e.com>

Pushed to drm-misc-next.

[1/1] HID: i2c-hid: Fix test in i2c_hid_core_register_panel_follower()
      commit: 5c76c794bf29399394ebacaa5af8436b8bed0d46