linux-kernel - Re: [PATCH net-next v01 10/12] hinic3: Add Rss function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250827095006.1595-1-gongfan1@huawei.com>
Date: Wed, 27 Aug 2025 17:50:06 +0800
From: Fan Gong <gongfan1@...wei.com>
To: <edumazet@...gle.com>
CC: <andrew+netdev@...n.ch>, <christophe.jaillet@...adoo.fr>,
	<corbet@....net>, <davem@...emloft.net>, <gongfan1@...wei.com>,
	<guoxin09@...wei.com>, <gur.stavi@...wei.com>, <helgaas@...nel.org>,
	<horms@...nel.org>, <jdamato@...tly.com>, <kuba@...nel.org>, <lee@...ger.us>,
	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<luosifu@...wei.com>, <meny.yossefi@...wei.com>, <mpe@...erman.id.au>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>,
	<przemyslaw.kitszel@...el.com>, <shenchenyang1@...ilicon.com>,
	<shijing34@...wei.com>, <sumang@...vell.com>, <vadim.fedorenko@...ux.dev>,
	<wulike1@...wei.com>, <zhoushuai28@...wei.com>, <zhuyikai1@...artners.com>
Subject: Re: [PATCH net-next v01 10/12] hinic3: Add Rss function

> > +static int alloc_rss_resource(struct net_device *netdev)
> > +{
> > +       struct hinic3_nic_dev *nic_dev =3D netdev_priv(netdev);
> > +       static const u8 default_rss_key[L2NIC_RSS_KEY_SIZE] =3D {
> > +               0x6d, 0x5a, 0x56, 0xda, 0x25, 0x5b, 0x0e, 0xc2,
> > +               0x41, 0x67, 0x25, 0x3d, 0x43, 0xa3, 0x8f, 0xb0,
> > +               0xd0, 0xca, 0x2b, 0xcb, 0xae, 0x7b, 0x30, 0xb4,
> > +               0x77, 0xcb, 0x2d, 0xa3, 0x80, 0x30, 0xf2, 0x0c,
> > +               0x6a, 0x42, 0xb7, 0x3b, 0xbe, 0xac, 0x01, 0xfa};
> > +
> > +       nic_dev->rss_hkey =3D kzalloc(L2NIC_RSS_KEY_SIZE, GFP_KERNEL);
> > +       if (!nic_dev->rss_hkey)
> > +               return -ENOMEM;
> > +
> > +       memcpy(nic_dev->rss_hkey, default_rss_key, L2NIC_RSS_KEY_SIZE);
> 
> I think you need to explain why you are not using netdev_rss_key_fill()

Thanks for your comment.
We use this default rss key for stable hashing effect but omit the rss attack
surface. We will modify this in next version.