linux-kernel - Re: [PATCH] firmware: meson_sm: fix device leak at probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aK7U7-ebrPcxwEIj@hovoldconsulting.com>
Date: Wed, 27 Aug 2025 11:50:39 +0200
From: Johan Hovold <johan@...nel.org>
To: Neil Armstrong <neil.armstrong@...aro.org>
Cc: Kevin Hilman <khilman@...libre.com>,
	Jerome Brunet <jbrunet@...libre.com>,
	Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
	Carlo Caione <ccaione@...libre.com>,
	linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] firmware: meson_sm: fix device leak at probe

On Fri, Jul 25, 2025 at 09:40:19AM +0200, Johan Hovold wrote:
> Make sure to drop the reference to the secure monitor device taken by
> of_find_device_by_node() when looking up its driver data on behalf of
> other drivers (e.g. during probe).
> 
> Note that holding a reference to the platform device does not prevent
> its driver data from going away so there is no point in keeping the
> reference after the helper returns.
> 
> Fixes: 8cde3c2153e8 ("firmware: meson_sm: Rework driver as a proper platform driver")
> Cc: stable@...r.kernel.org	# 5.5
> Cc: Carlo Caione <ccaione@...libre.com>
> Signed-off-by: Johan Hovold <johan@...nel.org>

Can someone pick this one up (along with the compile-test patch)?

Johan